JDK-8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds

[tstuefe]

May I please have reviews for this trivial fix.

We miss two "debug==false" requires rules on tests meant for non-debug only. Taking them out reduces test runtime on debug by ~20 seconds.

I also shifted some of the existing requires tags down to cluster them together in one place, for better clarity.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds

Reviewers

• Jie Fu (@DamonFool - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5571/head:pull/5571
$ git checkout pull/5571

Update a local copy of the PR:
$ git checkout pull/5571
$ git pull https://git.openjdk.java.net/jdk pull/5571/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5571

View PR using the GUI difftool:
$ git pr show -t 5571

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5571.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[tstuefe]

/label runtime

[openjdk]

@tstuefe The label runtime is not a valid label. These labels are valid:

• serviceability
• hotspot
• hotspot-compiler
• ide-support
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• security
• hotspot-runtime
• jmx
• build
• nio
• client
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr

[tstuefe]

/label hotspot-runtime

[openjdk]

@tstuefe
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (67fba3d3)

[DamonFool]

Looks good and trivial.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273958: gtest/MetaspaceGtests executes unnecessary tests in debug builds

Reviewed-by: jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Looks good and trivial.

Thank you!

[tstuefe]

/integrate

[openjdk]

Going to push as commit bb9d142.

[openjdk]

@tstuefe Pushed as commit bb9d142.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.