Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8273959: Some metaspace diagnostic switches should be develop #5573

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Sep 18, 2021

May I have reviews please for this fix.

The switches MetaspaceHandleDeallocations and MetaspaceGuardAllocations control debug-only features and consequently should be develop instead.

Unnecessary usage of -XX:+UnlockDiagnosticVMOptions is removed (in two cases unrelated to the changed switches).

/label hotspot-runtime


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273959: Some metaspace diagnostic switches should be develop

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5573/head:pull/5573
$ git checkout pull/5573

Update a local copy of the PR:
$ git checkout pull/5573
$ git pull https://git.openjdk.java.net/jdk pull/5573/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5573

View PR using the GUI difftool:
$ git pr show -t 5573

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5573.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 18, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr hotspot-runtime labels Sep 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2021

@tstuefe
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 18, 2021

Webrevs

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Sep 18, 2021

Do we need a CSR for this change?

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Sep 18, 2021

Do we need a CSR for this change?

God no :) These were diagnostic switches only used in tests (and I believe, only used by me).

Copy link
Member

@dholmes-ora dholmes-ora left a comment

LGTM!

Thanks,
David

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Sep 19, 2021

Copy link
Member

@DamonFool DamonFool left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273959: Some metaspace diagnostic switches should be develop

Reviewed-by: dholmes, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7c9868c: 8273454: C2: Transform (-a)(-b) into ab

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 20, 2021
@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Sep 20, 2021

Thank you @DamonFool and @dholmes-ora !

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Sep 20, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

Going to push as commit d2388b7.
Since your change was applied there have been 2 commits pushed to the master branch:

  • dc7f452: 8273815: move have_special_privileges to os_posix for POSIX platforms
  • 7c9868c: 8273454: C2: Transform (-a)(-b) into ab

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@tstuefe Pushed as commit d2388b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the JDK-8273959-Some-metaspace-diagnostic-switches-should-be-develop branch Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants