JDK-8273959: Some metaspace diagnostic switches should be develop

[tstuefe]

May I have reviews please for this fix.

The switches MetaspaceHandleDeallocations and MetaspaceGuardAllocations control debug-only features and consequently should be develop instead.

Unnecessary usage of -XX:+UnlockDiagnosticVMOptions is removed (in two cases unrelated to the changed switches).

/label hotspot-runtime

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273959: Some metaspace diagnostic switches should be develop

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Jie Fu (@DamonFool - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5573/head:pull/5573
$ git checkout pull/5573

Update a local copy of the PR:
$ git checkout pull/5573
$ git pull https://git.openjdk.java.net/jdk pull/5573/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5573

View PR using the GUI difftool:
$ git pr show -t 5573

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5573.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (90c575af)

[DamonFool]

Do we need a CSR for this change?

[tstuefe]

Do we need a CSR for this change?

God no :) These were diagnostic switches only used in tests (and I believe, only used by me).

[dholmes-ora]

LGTM!

Thanks,
David

[dholmes-ora]

@DamonFool for reference: https://wiki.openjdk.java.net/display/HotSpot/Hotspot+Command-line+Flags%3A+Kinds%2C+Lifecycle+and+the+CSR+Process

[DamonFool]

@DamonFool for reference: https://wiki.openjdk.java.net/display/HotSpot/Hotspot+Command-line+Flags%3A+Kinds%2C+Lifecycle+and+the+CSR+Process

Got it.
Thanks @dholmes-ora .

[DamonFool]

LGTM

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273959: Some metaspace diagnostic switches should be develop

Reviewed-by: dholmes, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 7c9868c: 8273454: C2: Transform (-a)(-b) into ab

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Thank you @DamonFool and @dholmes-ora !

[tstuefe]

/integrate

[openjdk]

Going to push as commit d2388b7.
Since your change was applied there have been 2 commits pushed to the master branch:

• dc7f452: 8273815: move have_special_privileges to os_posix for POSIX platforms
• 7c9868c: 8273454: C2: Transform (-a)(-b) into ab

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit d2388b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.