Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled #5576

Closed
wants to merge 1 commit into from

Conversation

theaoqi
Copy link
Member

@theaoqi theaoqi commented Sep 18, 2021

These tests failed with c2-only build:

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCompLevels.java
test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestControls.java
test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestRunTests.java

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5576/head:pull/5576
$ git checkout pull/5576

Update a local copy of the PR:
$ git checkout pull/5576
$ git pull https://git.openjdk.java.net/jdk pull/5576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5576

View PR using the GUI difftool:
$ git pr show -t 5576

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5576.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 18, 2021

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@theaoqi theaoqi marked this pull request as ready for review Sep 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2021

@theaoqi To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk openjdk bot added the rfr label Sep 18, 2021
@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Sep 18, 2021

/label compiler

@openjdk openjdk bot added the compiler label Sep 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2021

@theaoqi
The compiler label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 18, 2021

Webrevs

@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Sep 18, 2021

/label add hotspot-compiler
/label remove compiler
Sorry, hotspot-compiler may be the right list.

@openjdk openjdk bot added the hotspot-compiler label Sep 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2021

@theaoqi
The hotspot-compiler label was successfully added.

@openjdk openjdk bot removed the compiler label Sep 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2021

@theaoqi
The compiler label was successfully removed.

Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@theaoqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 6642d2e: 8273783: Simplify Metaspace arena guard handling
  • f242cb5: 8273797: Stop impersonating "server" VM in all VM variants
  • 240fa6e: 8273927: Enable hsdis for riscv64
  • 9c91ff5: 8274031: Typo in StringBuilder.readObject
  • d16bf04: 8273613: JFR: RemoteRecordingStream::start() blocks close()
  • 7ce60c6: 8273651: JFR: onMetadata(), setStartTime(), setEndTime() lacks test coverage
  • 1bd11a7: 8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out
  • ee3576a: 8256735: JFR: 'jfr' tool displays incorrect timestamps
  • 5fde4b6: 8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"
  • 04891c9: 8273912: Add threadControl_dumpThread(jthread) function
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/bb9d142759ece7665329b124a8ea0b16049b024a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 20, 2021
@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Sep 20, 2021

Thanks, @chhagedorn ! Should I get a second reviewer?

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me too.

@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Sep 21, 2021

Thanks, @TobiHartmann !

@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Sep 21, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@theaoqi
Your change (at version 74d9952) is now ready to be sponsored by a Committer.

@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Sep 22, 2021

Can anyone sponsor this?

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Sep 22, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

Going to push as commit 517405e.
Since your change was applied there have been 43 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 22, 2021
@openjdk openjdk bot removed the sponsor label Sep 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@kelthuzadx @theaoqi Pushed as commit 517405e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@theaoqi
Copy link
Member Author

@theaoqi theaoqi commented Sep 22, 2021

Thanks, @kelthuzadx !

@theaoqi theaoqi deleted the 8273965 branch Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
4 participants