-
Notifications
You must be signed in to change notification settings - Fork 6k
8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi #5577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi #5577
Conversation
👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into |
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code pre-dates for-each, the changes look okay.
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 242 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @alexmenkov, @sspitsyn, @plummercj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
src/jdk.jdi/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Andrey,
It looks good in general but I've inlined one comment.
Also, I need to mention it again that the formatting rules for casts do not require space as in here:
(InterfaceTypeImpl) interfaceType
Additional rule is at least to follow the local style in each file.
There are plenty of such spaces added in this PR.
Could you, please, fix them?
Thanks,
Serguei
src/jdk.jdi/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java
Outdated
Show resolved
Hide resolved
…k.jdi remove redundant spaces before casts
Thank you for review. Done. |
/integrate |
@turbanoff |
src/jdk.jdi/share/classes/com/sun/tools/jdi/InvokableTypeImpl.java
Outdated
Show resolved
Hide resolved
src/jdk.jdi/share/classes/com/sun/tools/jdi/InvokableTypeImpl.java
Outdated
Show resolved
Hide resolved
src/jdk.jdi/share/classes/com/sun/tools/jdi/InvokableTypeImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still extra space in the file InvokableTypeImpl.java.
…k.jdi remove empty space before casts in InvokableTypeImpl too
updated |
I also was going to comment on the space after each cast, but then I went in search of an openjdk java style guide and found this: http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html Which says to use a single space "After the closing parenthesis of a cast". Personally I don't like it, and I don't know if this is an official guide, but it's the only openjdk style guide I could find. I did also find the following, which says the same, but is not specifically for openjdk: https://google.github.io/styleguide/javaguide.html#s4.6-whitespace |
We had HotSpot convention about it. Not sure where it is located now. |
/sponsor |
@sspitsyn The PR has been updated since the change author (@turbanoff) issued the |
/integrate |
@turbanoff |
/sponsor |
Going to push as commit d5ccfa2.
Your commit was automatically rebased without conflicts. |
@sspitsyn @turbanoff Pushed as commit d5ccfa2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
There are few places in code where manual while loop is used with Iterator to iterate over Collection.
Instead of manual while cycles it's preferred to use enhanced-for cycle instead: it's less verbose, makes code easier to read and it's less error-prone.
It doesn't have any performance impact: java compiler generates similar code when compiling enhanced-for cycle.
Similar cleanups:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5577/head:pull/5577
$ git checkout pull/5577
Update a local copy of the PR:
$ git checkout pull/5577
$ git pull https://git.openjdk.java.net/jdk pull/5577/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5577
View PR using the GUI difftool:
$ git pr show -t 5577
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5577.diff