8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out

[mrserb]

This testcase creates two threads for each tag, one thread continuously change the profiles, the second thread use that profiles for color conversion. The first thread executed no more than 15 seconds, and the second thread should be stopped when the first thread end.

Unfortunately on the slow systems the second thread may occupy all cpu time, and will run forever since the first thread will not be able make even one iteration to stop the second thread. I was able to reproduce it by changing implementation of color conversion so it will do x10 more work.

The fix add a check to stop the second thread after 15 seconds.

@lawrence-andrew please take a look and confirm that it will work fine on your system

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5587/head:pull/5587
$ git checkout pull/5587

Update a local copy of the PR:
$ git checkout pull/5587
$ git pull https://git.openjdk.java.net/jdk pull/5587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5587

View PR using the GUI difftool:
$ git pr show -t 5587

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5587.diff

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (db3a6f28)

[lawrence-andrew]

Run the fixed testcase on the same host where the timeout was reproduced and the issue is not reproduced after running the test case several time and one more observation is test case run finish running faster.
Looks good to me!

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• ee3576a: 8256735: JFR: 'jfr' tool displays incorrect timestamps
• 5fde4b6: 8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"
• 04891c9: 8273912: Add threadControl_dumpThread(jthread) function

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

Going to push as commit 1bd11a7.
Since your change was applied there have been 3 commits pushed to the master branch:

• ee3576a: 8256735: JFR: 'jfr' tool displays incorrect timestamps
• 5fde4b6: 8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"
• 04891c9: 8273912: Add threadControl_dumpThread(jthread) function

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 1bd11a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.