Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272759: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java failed in timeout #5593

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Sep 21, 2021

Change the test to run in othervm mode.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272759: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java failed in timeout

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5593/head:pull/5593
$ git checkout pull/5593

Update a local copy of the PR:
$ git checkout pull/5593
$ git pull https://git.openjdk.java.net/jdk pull/5593/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5593

View PR using the GUI difftool:
$ git pr show -t 5593

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5593.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 21, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio label Sep 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2021

Webrevs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Sep 21, 2021

There isn't enough information in the JBS issue or this PR to comment on whether this test should be run in agentvm or othervm mode. From what I can see, the test periodically times out on macOS machines but I can't see if this is just older machines or whether there is a concern that output isn't seen in the .jtr file when run in agentvm mode.

@bplb
Copy link
Member Author

@bplb bplb commented Sep 21, 2021

All failures but one so far are on the same machine and all failures are on a MacPro5,1, which is vintage mid-2010. Otherwise, the logs do not contain significant useful information because of timing out.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

No objection to changing this test to othervm but if the timeouts are only seen on 2010 era Mac machines then I would think that the timeout will need to be increased, or the machines upgraded/replaced.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272759: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java failed in timeout

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

  • eeaf43b: 8274114: ProblemList serviceability/sa/TestJhsdbJstackMixed.java on linux-aarch64 in -Xcomp mode
  • 517405e: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
  • 11cddd3: 8272114: Unused _last_state in osThread_windows
  • cbe57e8: 8273684: Replace usages of java.util.Stack with ArrayDeque
  • a72c8aa: 8273921: Refactor NSK/JDI tests to create thread using factory
  • 161fdb4: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported
  • 0fc47e9: 8266666: Implementation for snippets
  • 6d91a3e: 8269039: Disable SHA-1 Signed JARs
  • 42d5d2a: 8274056: JavaAccessibilityUtilities leaks JNI objects
  • 57df0db: 8270873: JFR: Catch DirectoryIteratorException when scanning for .jfr files
  • ... and 64 more: https://git.openjdk.java.net/jdk/compare/cbffecc61e4a9ac1172926ef4f20d918d73adde9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 22, 2021
@bplb
Copy link
Member Author

@bplb bplb commented Sep 22, 2021

I am integrating this as is. If timeouts continue to be seen on ancient hardware then increasing the timeout may be considered at that point.

@bplb
Copy link
Member Author

@bplb bplb commented Sep 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

Going to push as commit 81d4164.
Since your change was applied there have been 90 commits pushed to the master branch:

  • da38ced: 8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family
  • d39aad9: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
  • c9de806: 8274039: codestrings gtest fails when hsdis is present
  • 33df388: 8274003: ProcessHandleImpl.Info toString has an if check which is always true
  • 0a36163: 8272600: (test) Use native "sleep" in Basic.java
  • c6df3c9: 8274071: Clean up java.lang.ref comments and documentation
  • 71788c6: 8271287: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected"
  • ba7d550: 8270139: jshell InternalError crash for import of @repeatable followed by unresolved ref
  • aefd4ac: 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak"
  • d245a8c: 8274069: Clean up g1ParScanThreadState a bit
  • ... and 80 more: https://git.openjdk.java.net/jdk/compare/cbffecc61e4a9ac1172926ef4f20d918d73adde9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@bplb Pushed as commit 81d4164.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the FileChannel-Transfer2GPlus-8272759 branch Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated nio
2 participants