8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI

[lawrence-andrew]

Problem :

1. Testcase was failing due to parse exception yesno
2. After removing yesno tag test frame and immediately get disposed

Fix :

1. Removed yesno tag
2. Show the test frame with pass, fail button. Now user can click on the `print' button to show the print dialog and take the print out and compare the print with the graphics rendered on the frame. Click either on the 'Pass' or 'Fail' button to make the pass or fail also clicking the 'Pass' or 'Fail' closes the test frame.
3. Added the timeout If not interaction is performed on the test frame.

@shurymury

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Pankaj Bansal (@pankaj-bansal - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5595/head:pull/5595
$ git checkout pull/5595

Update a local copy of the PR:
$ git checkout pull/5595
$ git pull https://git.openjdk.java.net/jdk pull/5595/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5595

View PR using the GUI difftool:
$ git pr show -t 5595

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5595.diff

[bridgekeeper]

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lawrence-andrew The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (105fc91f)
• 01: Full - Incremental (98a9e315)
• 00: Full (924167f9)

[openjdk]

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI

Reviewed-by: serb, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 291 new commits pushed to the master branch:

• d15fbc2: 8275187: Suppress warnings on non-serializable array component types in java.sql.rowset
• d8f6b6c: 8274718: runtime/cds/appcds/LambdaEagerInit.java fails with -XX:-CompactStrings
• 451a296: 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911
• 5ffb5d1: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules
• b8cb76a: 8273682: Upgrade Jline to 3.20.0
• dcf428c: 8275075: Remove unnecessary conversion to String in jdk.hotspot.agent
• c3b75c6: 8274516: [REDO] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references
• 337b73a: 8274851: [PPC64] Port zgc to linux on ppc64le
• cf82867: 8275049: [ZGC] missing null check in ZNMethod::log_register
• ab34cce: 8275186: Suppress warnings on non-serializable array component types in xml
• ... and 281 more: https://git.openjdk.java.net/jdk/compare/9c91ff57e8b4b48e997e0424ff93b29e695ec527...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @pankaj-bansal) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lawrence-andrew]

/integrate

[openjdk]

@lawrence-andrew
Your change (at version 105fc91) is now ready to be sponsored by a Committer.

[mrserb]

@pankaj-bansal please take a look, did your comment was fixed?

[pankaj-bansal]

@pankaj-bansal please take a look, did your comment was fixed?

Yes, I see that my comment has been take care of.

[mrserb]

/sponsor

[openjdk]

Going to push as commit 7dc2db4.
Since your change was applied there have been 292 commits pushed to the master branch:

• 1e0184d: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList
• d15fbc2: 8275187: Suppress warnings on non-serializable array component types in java.sql.rowset
• d8f6b6c: 8274718: runtime/cds/appcds/LambdaEagerInit.java fails with -XX:-CompactStrings
• 451a296: 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911
• 5ffb5d1: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules
• b8cb76a: 8273682: Upgrade Jline to 3.20.0
• dcf428c: 8275075: Remove unnecessary conversion to String in jdk.hotspot.agent
• c3b75c6: 8274516: [REDO] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references
• 337b73a: 8274851: [PPC64] Port zgc to linux on ppc64le
• cf82867: 8275049: [ZGC] missing null check in ZNMethod::log_register
• ... and 282 more: https://git.openjdk.java.net/jdk/compare/9c91ff57e8b4b48e997e0424ff93b29e695ec527...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb @lawrence-andrew Pushed as commit 7dc2db4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.