Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8274317: Unnecessary reentrant synchronized block in java.awt.Cursor #5597

Closed
wants to merge 1 commit into from
Closed

8274317: Unnecessary reentrant synchronized block in java.awt.Cursor #5597

wants to merge 1 commit into from

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 21, 2021 •
edited by openjdk bot

No need to use 'synchronized(systemCustomCursors)' in 2 places. One is enough.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274317: Unnecessary reentrant synchronized block in java.awt.Cursor

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5597/head:pull/5597
$ git checkout pull/5597

Update a local copy of the PR:
$ git checkout pull/5597
$ git pull https://git.openjdk.java.net/jdk pull/5597/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5597

View PR using the GUI difftool:
$ git pr show -t 5597

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5597.diff

@turbanoff
[PATCH] Remove reentrant synchronized block in java.awt.Cursor.loadSy…
9041bfa 
…stemCustomCursorProperties

No need to use 'synchronized(systemCustomCursors)' in 2 places. One is enough.
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 21, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 21, 2021
@mrserb
Copy link
Member

mrserb commented Sep 25, 2021

Looks fine.

@turbanoff turbanoff changed the title [PATCH] Remove reentrant synchronized block in java.awt.Cursor.loadSystemCustomCursorProperties 8274317: Unnecessary reentrant synchronized block in java.awt.Cursor Sep 25, 2021
@openjdk
Copy link

openjdk bot commented Sep 25, 2021 •
edited

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274317: Unnecessary reentrant synchronized block in java.awt.Cursor

Reviewed-by: serb, pbansal, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

  • 252aaa9: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 7700b25: 8273401: Disable JarIndex support in URLClassPath
  • 5ec1cdc: 8274321: Standardize values of @SInCE tags in javax.lang.model
  • 4838a2c: 8274143: Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty
  • ab28db1: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
  • 8c122af: 8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc
  • 9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare
  • 5756385: 8274273: Update testing docs for MacOS with Non-US locale
  • 61ac53f: 8210927: JDB tests do not update source path after doing a redefine class
  • 341de49: 8273492: Move evacuation failure handling into G1YoungCollector
  • ... and 70 more: https://git.openjdk.java.net/jdk/compare/6642d2eb8b129a2291191647197c5b3333a32989...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @pankaj-bansal, @prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2021

Webrevs

pankaj-bansal
pankaj-bansal approved these changes Sep 25, 2021
View reviewed changes
Copy link

@pankaj-bansal pankaj-bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@turbanoff
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 26, 2021
@openjdk
Copy link

openjdk bot commented Sep 26, 2021

@turbanoff
Your change (at version 9041bfa) is now ready to be sponsored by a Committer.

@pankaj-bansal
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 27, 2021

Going to push as commit 7436a77.
Since your change was applied there have been 82 commits pushed to the master branch:

  • 7426fd4: 8274325: C4819 warning at vm_version_x86.cpp on Windows after JDK-8234160
  • e3aff8f: 8274289: jdk/jfr/api/consumer/TestRecordedFrameType.java failed with "RuntimeException: assertNotEquals: expected Interpreted to not equal Interpreted"
  • 252aaa9: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 7700b25: 8273401: Disable JarIndex support in URLClassPath
  • 5ec1cdc: 8274321: Standardize values of @SInCE tags in javax.lang.model
  • 4838a2c: 8274143: Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty
  • ab28db1: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
  • 8c122af: 8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc
  • 9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare
  • 5756385: 8274273: Update testing docs for MacOS with Non-US locale
  • ... and 72 more: https://git.openjdk.java.net/jdk/compare/6642d2eb8b129a2291191647197c5b3333a32989...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 27, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 27, 2021
@openjdk
Copy link

openjdk bot commented Sep 27, 2021

@pankaj-bansal @turbanoff Pushed as commit 7436a77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the redundant_sync_java.awt.Cursor.loadSystemCursorProperties branch October 4, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankaj-bansal pankaj-bansal pankaj-bansal approved these changes

@mrserb mrserb mrserb approved these changes

@prrace prrace prrace approved these changes

Assignees
No one assigned
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
4 participants
@turbanoff @mrserb @pankaj-bansal @prrace