Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8272703: StressSeed should be set via FLAG_SET_ERGO #5599

Closed
wants to merge 3 commits into from

Conversation

tobiasholenstein
Copy link
Contributor

@tobiasholenstein tobiasholenstein commented Sep 21, 2021

Set the StressSeed (added by JDK-8252219) via FLAG_SET_ERGO if the seed is generated by the VM (i.e., not set via the command line). This way, StressSeed will be added to the "[Global flags]" section of the hs_err file on crash and can be used to reproduce the issue.

If RepeatCompilation is on and no StressSeed is set, a new StressSeed is generated for every compilation. The reason for this is that some Bugs are only triggered intermittent, because they depend on the StressSeed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272703: StressSeed should be set via FLAG_SET_ERGO

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5599/head:pull/5599
$ git checkout pull/5599

Update a local copy of the PR:
$ git checkout pull/5599
$ git pull https://git.openjdk.java.net/jdk pull/5599/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5599

View PR using the GUI difftool:
$ git pr show -t 5599

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5599.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 21, 2021

👋 Welcome back tobiasholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@tobiasholenstein The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Sep 21, 2021
@tobiasholenstein tobiasholenstein marked this pull request as ready for review Sep 21, 2021
@openjdk openjdk bot added the rfr label Sep 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2021

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

That looks good to me. I think it's valuable to still generate new seeds when running with RepeatCompilation which helped quite a lot to reproduce bugs in the past which were otherwise hard to trigger.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272703: StressSeed should be set via FLAG_SET_ERGO

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • eeaf43b: 8274114: ProblemList serviceability/sa/TestJhsdbJstackMixed.java on linux-aarch64 in -Xcomp mode
  • 517405e: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
  • 11cddd3: 8272114: Unused _last_state in osThread_windows
  • cbe57e8: 8273684: Replace usages of java.util.Stack with ArrayDeque
  • a72c8aa: 8273921: Refactor NSK/JDI tests to create thread using factory
  • 161fdb4: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported
  • 0fc47e9: 8266666: Implementation for snippets
  • 6d91a3e: 8269039: Disable SHA-1 Signed JARs
  • 42d5d2a: 8274056: JavaAccessibilityUtilities leaks JNI objects
  • 57df0db: 8270873: JFR: Catch DirectoryIteratorException when scanning for .jfr files
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/c60bcd09b73f6ad176bbd73fe3c1a09545609353...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 21, 2021
@tobiasholenstein
Copy link
Contributor Author

@tobiasholenstein tobiasholenstein commented Sep 21, 2021

That looks good to me. I think it's valuable to still generate new seeds when running with RepeatCompilation which helped quite a lot to reproduce bugs in the past which were otherwise hard to trigger.

Thanks! @chhagedorn

@tobiasholenstein
Copy link
Contributor Author

@tobiasholenstein tobiasholenstein commented Sep 21, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@tobiasholenstein
Your change (at version 8a5f014) is now ready to be sponsored by a Committer.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

Going to push as commit 66ce09f.
Since your change was applied there have been 46 commits pushed to the master branch:

  • c434528: 8273546: DecimalFormat documentation contains literal HTML character references
  • d098751: 8273916: Remove 'special' ranking
  • 4f3b626: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions
  • 8799856: 8274075: Fix miscellaneous typos in java.base
  • 8b833bb: 8274048: IGV: Replace usages of Collections.sort with List.sort call
  • a74c099: 8252842: Extend jmap to support parallel heap dump
  • 2166ed1: 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral
  • 1c6fa11: 8273979: move some os time related functions to os_posix for POSIX platforms
  • 45adc92: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
  • 0fbbe4c: 8274033: Some tier-4 CDS EpsilonGC tests throw OOM
  • ... and 36 more: https://git.openjdk.java.net/jdk/compare/c60bcd09b73f6ad176bbd73fe3c1a09545609353...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@TobiHartmann @tobiasholenstein Pushed as commit 66ce09f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants