Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274053: [BACKOUT] JDK-8270842: G1: Only young regions need to redirty outside references in remset. #5600

Closed
wants to merge 1 commit into from

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Sep 21, 2021

Hi all,

can I have reviews for this clean backout of JDK-8270842/PR#4853 because it is buggy - it drops re-scanning of failed objects in old generation during self-forward removal. However the previous attempt to mark the card of the discovered reference field for j.l.ref.References might not have been processed correctly as the card table may not be in a state to properly handle regular write barrier writes. More information in PR#5037.

I will follow-up with a correct solution.

Testing: GHA (this is a clean backout)

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274053: [BACKOUT] JDK-8270842: G1: Only young regions need to redirty outside references in remset.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5600/head:pull/5600
$ git checkout pull/5600

Update a local copy of the PR:
$ git checkout pull/5600
$ git pull https://git.openjdk.java.net/jdk pull/5600/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5600

View PR using the GUI difftool:
$ git pr show -t 5600

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5600.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 21, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274053: [BACKOUT] JDK-8270842: G1: Only young regions need to redirty outside references in remset.

Reviewed-by: sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@kstefanj
Copy link
Contributor

@kstefanj kstefanj commented Sep 21, 2021

And since it is small and a clean back-out we can consider it trivial.

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Sep 21, 2021

Thanks @kstefanj for your review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

Going to push as commit afd218d.

@openjdk openjdk bot closed this Sep 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@tschatzl Pushed as commit afd218d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants