New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8267853: Remove unused styles from stylesheet #5601
Conversation
|
@hns this pull request can not be integrated into git checkout JDK-8267853
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@hns This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
/integrate |
Going to push as commit e1f0df0. |
Please review a simple change to remove unused stylesheet classes, conveniently exposed by
CheckStylesheetClasses.java
.I have 1) grepped the generated documentation for the removed classes without finding any occurrences, and 2) compared the generated documentation in the browser page by page without finding any differences.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5601/head:pull/5601
$ git checkout pull/5601
Update a local copy of the PR:
$ git checkout pull/5601
$ git pull https://git.openjdk.java.net/jdk pull/5601/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5601
View PR using the GUI difftool:
$ git pr show -t 5601
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5601.diff