8274056 JavaAccessibilityUtilities leaks JNI objects

[savoptik]

The following methods in JavaAccessibilityUtilities leak JNI objects got from up-calls to Java:

• getAxComponentSize
• getJavaRole

Also, getAxComponentSize calls jm_getSize on wrong class.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274056: JavaAccessibilityUtilities leaks JNI objects

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Anton Tarasov (@forantar - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5602/head:pull/5602
$ git checkout pull/5602

Update a local copy of the PR:
$ git checkout pull/5602
$ git pull https://git.openjdk.java.net/jdk pull/5602/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5602

View PR using the GUI difftool:
$ git pr show -t 5602

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5602.diff

[bridgekeeper]

👋 Welcome back savoptik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[savoptik]

/reviewer credit @forantar

[openjdk]

@savoptik The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[savoptik]

/reviewer credit @forantar

[openjdk]

@savoptik
Reviewer ant successfully credited.

[openjdk]

@savoptik
Reviewer ant successfully credited.

[mlbridge]

Webrevs

• 00: Full (cb72efda)

[openjdk]

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274056: JavaAccessibilityUtilities leaks JNI objects

Reviewed-by: aivanov, ant

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 111d5e1: 8273915: Create 'nosafepoint' rank
• 7acec3f: 8236505: Mark jdk/editpad/EditPadTest.java as @headful
• afd218d: 8274053: [BACKOUT] JDK-8270842: G1: Only young regions need to redirty outside references in remset.
• a5108a6: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @forantar) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[aivanov-jdk]

I would appreciate if you add more details in the description of the PR. Copying that from the JBS would be enough.

[aivanov-jdk]

I expect @forantar will also take a look and approve.

[savoptik]

/integrate

[openjdk]

@savoptik
Your change (at version cb72efd) is now ready to be sponsored by a Committer.

[forantar]

/sponsor

[openjdk]

Going to push as commit 42d5d2a.
Since your change was applied there have been 5 commits pushed to the master branch:

• 57df0db: 8270873: JFR: Catch DirectoryIteratorException when scanning for .jfr files
• 111d5e1: 8273915: Create 'nosafepoint' rank
• 7acec3f: 8236505: Mark jdk/editpad/EditPadTest.java as @headful
• afd218d: 8274053: [BACKOUT] JDK-8270842: G1: Only young regions need to redirty outside references in remset.
• a5108a6: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher

Your commit was automatically rebased without conflicts.

[openjdk]

@forantar @savoptik Pushed as commit 42d5d2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.