8274069: Clean up g1ParScanThreadState a bit

[tschatzl]

Hi all,

can I have reviews for this change that does some minor refactoring for issues found in JDK-8271880/PR#5037:

• remove declaration without definition
• move inlined code in the .hpp file into .inline.hpp file
• factor out some code

Testing: gha, local compilation, local gc/g1

Thanks,
Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274069: Clean up g1ParScanThreadState a bit

Reviewers

• Stefan Johansson (@kstefanj - Reviewer) ⚠️ Review applies to 53997bc
• Albert Mingkun Yang (@albertnetymk - Reviewer) ⚠️ Review applies to 8cf9b6a
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5607/head:pull/5607
$ git checkout pull/5607

Update a local copy of the PR:
$ git checkout pull/5607
$ git pull https://git.openjdk.java.net/jdk pull/5607/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5607

View PR using the GUI difftool:
$ git pr show -t 5607

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5607.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (5d3a28bd)
• 02: Full - Incremental (769254c8)
• 01: Full - Incremental (8cf9b6a9)
• 00: Full (53997bce)

[kstefanj]

👍

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274069: Clean up g1ParScanThreadState a bit

Reviewed-by: sjohanss, ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 161fdb4: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported
• 0fc47e9: 8266666: Implementation for snippets
• 6d91a3e: 8269039: Disable SHA-1 Signed JARs
• 42d5d2a: 8274056: JavaAccessibilityUtilities leaks JNI objects
• 57df0db: 8270873: JFR: Catch DirectoryIteratorException when scanning for .jfr files
• 111d5e1: 8273915: Create 'nosafepoint' rank
• 7acec3f: 8236505: Mark jdk/editpad/EditPadTest.java as @headful

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

The old name, enqueue_card_after_barrier_filters, is still referenced in the comments.

(I also wonder if it makes sense to unify all callers of enqueue_card_if_tracked to use write_ref_field_post with template non-type arguments. Not in this PR ofc.)

[kimbarrett]

Does this change allow this inclusion of an .inline.hpp to be moved out of the .hpp?
33 #include "gc/g1/heapRegionRemSet.inline.hpp"

[tschatzl]

Does this change allow this inclusion of an .inline.hpp to be moved out of the .hpp?
33 #include "gc/g1/heapRegionRemSet.inline.hpp"

In the latest change I also touched up includes in that file a bit. Nothing about heapRegionRemSet has been used in that file...

[kimbarrett]

Looks good.

[tschatzl]

Thanks @albertnetymk @kstefanj @kimbarrett for your reviews.

/integrate

[openjdk]

Going to push as commit d245a8c.
Since your change was applied there have been 18 commits pushed to the master branch:

• 3f73ca7: 8274068: Rename G1ScanInYoungSetter to G1SkipCardEnqueueSetter
• 7f78803: 8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character
• 51085b5: 8274054: Add custom enqueue calls during reference processing
• c77ebe8: 8274060: C2: Incorrect computation after JDK-8273454
• d9872ba: 8273590: Move helper classes in G1 post evacuation sub tasks to cpp files
• 688b3fe: 8274070: Rectify problemlist platform for failing test on macos12
• eeaf43b: 8274114: ProblemList serviceability/sa/TestJhsdbJstackMixed.java on linux-aarch64 in -Xcomp mode
• 517405e: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
• 11cddd3: 8272114: Unused _last_state in osThread_windows
• cbe57e8: 8273684: Replace usages of java.util.Stack with ArrayDeque
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/afd218d39a3125fcea50968edef6e6cfbacfff50...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit d245a8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.