New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8254234 - Add test library stream object builder #561
8254234 - Add test library stream object builder #561
Conversation
👋 Welcome back chegar! A progress list of the required criteria for merging this PR into |
@ChrisHegarty The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
@ChrisHegarty This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@ChrisHegarty Since your change was applied there have been 35 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit aad3cf4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
It is useful to have a test library facility for building stream objects, suitable for deserialization testing. We already have a partial implementation in one of the record serialization tests, move it to the test library for more general use. The implementation remains partial, but can be expanded as and when needed.
Progress
Testing
Failed test tasks
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/561/head:pull/561
$ git checkout pull/561