Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN #5614

Closed

Conversation

@tobiasholenstein
Copy link
Contributor

@tobiasholenstein tobiasholenstein commented Sep 21, 2021

Added the keys "randomness" and "stress" to the JTreg tests which use StressGCM, StressLCM and/or StressIGVN and did not use the keys before.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5614/head:pull/5614
$ git checkout pull/5614

Update a local copy of the PR:
$ git checkout pull/5614
$ git pull https://git.openjdk.java.net/jdk pull/5614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5614

View PR using the GUI difftool:
$ git pr show -t 5614

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5614.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 21, 2021

👋 Welcome back tobiasholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@tobiasholenstein The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2021

Webrevs

@tobiasholenstein tobiasholenstein changed the title JDK-8270156: Add randomness and stress keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN JDK-8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN Sep 22, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good and trivial to me.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • 66ce09f: 8272703: StressSeed should be set via FLAG_SET_ERGO
  • c434528: 8273546: DecimalFormat documentation contains literal HTML character references
  • d098751: 8273916: Remove 'special' ranking
  • 4f3b626: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions
  • 8799856: 8274075: Fix miscellaneous typos in java.base
  • 8b833bb: 8274048: IGV: Replace usages of Collections.sort with List.sort call
  • a74c099: 8252842: Extend jmap to support parallel heap dump
  • 2166ed1: 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral
  • 1c6fa11: 8273979: move some os time related functions to os_posix for POSIX platforms
  • 45adc92: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/afd218d39a3125fcea50968edef6e6cfbacfff50...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 22, 2021
Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good!

@tobiasholenstein
Copy link
Contributor Author

@tobiasholenstein tobiasholenstein commented Sep 23, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@tobiasholenstein
Your change (at version eae2db0) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

Going to push as commit 653a612.
Since your change was applied there have been 44 commits pushed to the master branch:

  • 66ce09f: 8272703: StressSeed should be set via FLAG_SET_ERGO
  • c434528: 8273546: DecimalFormat documentation contains literal HTML character references
  • d098751: 8273916: Remove 'special' ranking
  • 4f3b626: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions
  • 8799856: 8274075: Fix miscellaneous typos in java.base
  • 8b833bb: 8274048: IGV: Replace usages of Collections.sort with List.sort call
  • a74c099: 8252842: Extend jmap to support parallel heap dump
  • 2166ed1: 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral
  • 1c6fa11: 8273979: move some os time related functions to os_posix for POSIX platforms
  • 45adc92: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/afd218d39a3125fcea50968edef6e6cfbacfff50...master

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@TobiHartmann @tobiasholenstein Pushed as commit 653a612.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants