Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274083: Update testing docs to mention tiered testing #5615

Closed
wants to merge 7 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 21, 2021

Now that OpenJDK has more or less complete tier{1,2,3,4} definitions, let's mention them in testing.md.

Current patch is my braindump, I am open for suggestions :)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274083: Update testing docs to mention tiered testing

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5615/head:pull/5615
$ git checkout pull/5615

Update a local copy of the PR:
$ git checkout pull/5615
$ git pull https://git.openjdk.java.net/jdk pull/5615/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5615

View PR using the GUI difftool:
$ git pr show -t 5615

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5615.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 21, 2021
@openjdk
Copy link

openjdk bot commented Sep 21, 2021

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Sep 21, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2021

Webrevs

doc/testing.html Outdated Show resolved Hide resolved
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Aleksey,

I don't have any significant misgivings about this version - thanks.

One correction needed below.

Thanks,
David

doc/testing.html Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Sep 23, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274083: Update testing docs to mention tiered testing

Reviewed-by: dholmes, jiefu, stuefe, ihse, mseledtsov, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

  • 56b8b35: 8273261: Replace 'while' cycles with iterator with enhanced-for in java.base
  • 0aa63fe: 8274216: ProblemList 2 serviceability/dcmd/gc tests with ZGC on linux-all and windows-all
  • 5ffbe75: 8274195: Doc cleanup in java.nio.file
  • 1fdc656: 8274175: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java still failed in timeout
  • 3b1b8fc: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • 1b7f4b7: 8274169: HotSpot Style Guide has stale link to chromium style guide
  • 653a612: 8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN
  • 66ce09f: 8272703: StressSeed should be set via FLAG_SET_ERGO
  • c434528: 8273546: DecimalFormat documentation contains literal HTML character references
  • d098751: 8273916: Remove 'special' ranking
  • ... and 61 more: https://git.openjdk.java.net/jdk/compare/48aff23165db668eb9c06477d16a8e72b6dc6b56...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2021
doc/testing.md Show resolved Hide resolved
Copy link
Member

@DamonFool DamonFool left a comment

LGTM.

Thanks for this kind of doc update.

Copy link
Member

@tstuefe tstuefe left a comment

I like this. Thanks for doing this (and for the actual definition of the tiers). This hopefully makes communicating about test coverage much easier.

As I understood, tier1-3 are the same as Oracle tier1-3?

Copy link
Member

@magicus magicus left a comment

I think this looks overall good. Just do something about that GHA link and I'm perfectly happy! :)

doc/testing.md Outdated Show resolved Hide resolved
doc/testing.html Outdated Show resolved Hide resolved
doc/testing.html Outdated Show resolved Hide resolved
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2021

Mailing list message from David Holmes on build-dev:

On 23/09/2021 8:33 pm, Thomas Stuefe wrote:

On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's mention them in `testing.md`.

Current patch is my braindump, I am open for suggestions :)

Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:

More fixes

I like this. Thanks for doing this (and for the actual definition of the tiers). This hopefully makes communicating about test coverage much easier.

As I understood, tier1-3 are the same as Oracle tier1-3?

Not exactly no. Our tier definitions are tuples of (tests, platforms,
flags). The sets of tests will be close but not exactly the same.

David

Copy link
Member

@mseledts mseledts left a comment

Change looks good to me, thank you.

doc/testing.html Outdated Show resolved Hide resolved
@shipilev
Copy link
Member Author

shipilev commented Sep 24, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 24, 2021

Going to push as commit 971aa35.
Since your change was applied there have been 73 commits pushed to the master branch:

  • 1d44014: 8273034: Make javadoc navigation collapsible on small displays
  • bb74ae8: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches
  • 56b8b35: 8273261: Replace 'while' cycles with iterator with enhanced-for in java.base
  • 0aa63fe: 8274216: ProblemList 2 serviceability/dcmd/gc tests with ZGC on linux-all and windows-all
  • 5ffbe75: 8274195: Doc cleanup in java.nio.file
  • 1fdc656: 8274175: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java still failed in timeout
  • 3b1b8fc: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • 1b7f4b7: 8274169: HotSpot Style Guide has stale link to chromium style guide
  • 653a612: 8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN
  • 66ce09f: 8272703: StressSeed should be set via FLAG_SET_ERGO
  • ... and 63 more: https://git.openjdk.java.net/jdk/compare/48aff23165db668eb9c06477d16a8e72b6dc6b56...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 24, 2021
@openjdk
Copy link

openjdk bot commented Sep 24, 2021

@shipilev Pushed as commit 971aa35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Looks good to me.

@shipilev shipilev deleted the JDK-8274083-docs-tiered branch Oct 11, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2021

Mailing list message from Joseph D. Darcy on build-dev:

On 9/23/2021 11:00 PM, Alan Bateman wrote:

On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's mention them in `testing.md`.

Current patch is my braindump, I am open for suggestions :)
Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:

More fixes
Marked as reviewed by alanb (Reviewer).

doc/testing.html line 80:

78: <ul>
79: <li><p><code>tier1</code>: This is the lowest test tier. Multiple developers run these tests every day. Because of the widespread use, the tests in <code>tier1</code> are carefully selected and optimized to run fast, and to run in the most stable manner. The test failures in <code>tier1</code> are usually followed up on quickly, either with fixes, or adding relevant tests to problem list. GitHub Actions workflows, if enabled, run <code>tier1</code> tests.</p></li>
80: <li><p><code>tier2</code>: This test group covers even more ground. These contain, among other things, tests that either run for too long to be at <code>tier1</code>, or may require special configuration, or tests that are less stable, or cover the broader range of less critical JVM and JDK features/components (for example, jaxp).</p></li>
Thanks for the updates, I think it reads much better now.
A small suggestion is to change "less critical" to "non-core", and "jaxp" to "XML" as I don't expect too many people know what JAXP is.

Catching up on email, for some belated context, the initial tired
testing email thread did included some discussion about what the tiered
were intended to mean including:

http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-March/001991.html

Thanks,

-Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
8 participants