Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274003: ProcessHandleImpl.Info toString has an if check which is always true #5618

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Sep 21, 2021

Correct the check if any field has been appended to the StringBuilder in ProcessHandleImpl.Info.toString().


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274003: ProcessHandleImpl.Info toString has an if check which is always true

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5618/head:pull/5618
$ git checkout pull/5618

Update a local copy of the PR:
$ git checkout pull/5618
$ git pull https://git.openjdk.java.net/jdk pull/5618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5618

View PR using the GUI difftool:
$ git pr show -t 5618

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5618.diff

…ays true

Correct the check if any field has been appended to the StringBuilder.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 21, 2021

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Sep 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2021

Webrevs

bplb
bplb approved these changes Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274003: ProcessHandleImpl.Info toString has an if check which is always true

Reviewed-by: bpb, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 21, 2021
naotoj
naotoj approved these changes Sep 21, 2021
@RogerRiggs
Copy link
Contributor Author

@RogerRiggs RogerRiggs commented Sep 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

Going to push as commit 33df388.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 0a36163: 8272600: (test) Use native "sleep" in Basic.java
  • c6df3c9: 8274071: Clean up java.lang.ref comments and documentation
  • 71788c6: 8271287: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected"
  • ba7d550: 8270139: jshell InternalError crash for import of @repeatable followed by unresolved ref
  • aefd4ac: 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak"
  • d245a8c: 8274069: Clean up g1ParScanThreadState a bit
  • 3f73ca7: 8274068: Rename G1ScanInYoungSetter to G1SkipCardEnqueueSetter
  • 7f78803: 8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character
  • 51085b5: 8274054: Add custom enqueue calls during reference processing
  • c77ebe8: 8274060: C2: Incorrect computation after JDK-8273454
  • ... and 29 more: https://git.openjdk.java.net/jdk/compare/b3b4b1cc218d4c02809eb7fd4d83d541acfbd9bd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@RogerRiggs Pushed as commit 33df388.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8274003-processhandle-extra-comma branch Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
4 participants