Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274114: ProblemList serviceability/sa/TestJhsdbJstackMixed.java on linux-aarch64 in -Xcomp mode #5624

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Sep 22, 2021

A trivial fix to ProblemList serviceability/sa/TestJhsdbJstackMixed.java on linux-aarch64 in -Xcomp mode.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274114: ProblemList serviceability/sa/TestJhsdbJstackMixed.java on linux-aarch64 in -Xcomp mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5624/head:pull/5624
$ git checkout pull/5624

Update a local copy of the PR:
$ git checkout pull/5624
$ git pull https://git.openjdk.java.net/jdk pull/5624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5624

View PR using the GUI difftool:
$ git pr show -t 5624

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5624.diff

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Sep 22, 2021

/label add hotspot-runtime
/label add serviceability

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 22, 2021
@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 22, 2021
@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Sep 22, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2021

Webrevs

Copy link
Contributor

@plummercj plummercj left a comment

Approved and trivial.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Sep 22, 2021

@plummercj - Thanks for the fast review!

@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274114: ProblemList serviceability/sa/TestJhsdbJstackMixed.java on linux-aarch64 in -Xcomp mode

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 517405e: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
  • 11cddd3: 8272114: Unused _last_state in osThread_windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 22, 2021
@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Sep 22, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2021

Going to push as commit eeaf43b.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 517405e: 8273965: some testlibrary_tests/ir_framework tests fail when c1 disabled
  • 11cddd3: 8272114: Unused _last_state in osThread_windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2021
@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@dcubed-ojdk Pushed as commit eeaf43b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8274114 branch Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants