Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274425: Remove unused Modules.extraLimitMods #5628

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 22, 2021

HashSet com.sun.tools.javac.comp.Modules.extraLimitMods is always empty. Code only check its content, but no content added.
There was a method addExtraLimitModules, but it was removed under JDK-8175191 253fdcd
Method addExtraLimitModules itself was added in ec9ca29, but was never actually used .


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5628/head:pull/5628
$ git checkout pull/5628

Update a local copy of the PR:
$ git checkout pull/5628
$ git pull https://git.openjdk.java.net/jdk pull/5628/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5628

View PR using the GUI difftool:
$ git pr show -t 5628

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5628.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Sep 22, 2021
@turbanoff turbanoff changed the title [PATCH] Remove unused Modules.extraLimitMods 8274425: Remove unused Modules.extraLimitMods Sep 28, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 28, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2021

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2021

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2021

@turbanoff This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Nov 23, 2021
@turbanoff
Copy link
Member Author

turbanoff commented Nov 23, 2021

/open

@openjdk openjdk bot reopened this Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@turbanoff This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2021

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@turbanoff
Copy link
Member Author

turbanoff commented Feb 4, 2022

Can I get the review, please?

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2022

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@turbanoff
Copy link
Member Author

turbanoff commented Mar 30, 2022

Let's wait for reviewers a bit more

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2022

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2022

@turbanoff This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org rfr Pull request is ready for review
1 participant