Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275241: Unused ArrayList is created in RequestEngine.addHooks #5629

Closed

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 22, 2021

Local ArrayList<RequestHook> is created in a method RequestEngine.addHooks. Elements are added to it, but then content is unused. Seems leftovers from some refactoring.
Found by IntelliJ IDEA inspection "Mismatched query and update of collection"


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275241: Unused ArrayList is created in RequestEngine.addHooks

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5629/head:pull/5629
$ git checkout pull/5629

Update a local copy of the PR:
$ git checkout pull/5629
$ git pull https://git.openjdk.java.net/jdk pull/5629/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5629

View PR using the GUI difftool:
$ git pr show -t 5629

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5629.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 22, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr label Sep 22, 2021
@turbanoff turbanoff changed the title [PATCH] Unused ArrayList is created in RequestEngine.addHooks 8275241: Unused ArrayList is created in RequestEngine.addHooks Oct 13, 2021
@openjdk openjdk bot added the rfr label Oct 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 13, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275241: Unused ArrayList is created in RequestEngine.addHooks

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 277 new commits pushed to the master branch:

  • 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
  • 8b1b6f9: 8269559: AArch64: Implement string_compare intrinsic in SVE
  • d9e03e4: 8275244: Suppress warnings on non-serializable array component types in jdk.management
  • 7dc2db4: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
  • 1e0184d: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList
  • d15fbc2: 8275187: Suppress warnings on non-serializable array component types in java.sql.rowset
  • d8f6b6c: 8274718: runtime/cds/appcds/LambdaEagerInit.java fails with -XX:-CompactStrings
  • 451a296: 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911
  • 5ffb5d1: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules
  • b8cb76a: 8273682: Upgrade Jline to 3.20.0
  • ... and 267 more: https://git.openjdk.java.net/jdk/compare/eeaf43b229941f49326ed6d0f37e77f6f0ce5409...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@egahlin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 13, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 14, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@turbanoff
Your change (at version 1794ba1) is now ready to be sponsored by a Committer.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 11, 2021

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@egahlin
Copy link
Member

@egahlin egahlin commented Nov 29, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

Going to push as commit 37de442.
Since your change was applied there have been 858 commits pushed to the master branch:

  • 72bacf8: 8276108: Wrong instruction generation in aarch64 backend
  • e3e5908: 8277847: Support toolGuide tag in class-level documentation
  • 9a3a9b1: 8277865: G1: Change integer division to floating point division
  • aed53ee: 8264838: IGV: enhance graph export functionality
  • 0c7a4b8: 8277842: IGV: Add jvms property to know where a node came from
  • c3a7f2f: 8277382: make c1 BlockMerger use IR::verify only when necessary
  • 8f9eb62: 8274784: jshell: Garbled character was displayed by System.out.println(...) on Japanese Windows
  • e9b36a8: 8276670: G1: Rename G1CardSetFreePool and related classes
  • b9eb532: 8276685: Malformed Javadoc inline tags in JDK source in /jdk/management/jfr/RecordingInfo.java
  • 40fef23: 8275908: Record null_check traps for calls and array_check traps in the interpreter
  • ... and 848 more: https://git.openjdk.java.net/jdk/compare/eeaf43b229941f49326ed6d0f37e77f6f0ce5409...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@egahlin @turbanoff Pushed as commit 37de442.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr integrated
2 participants