Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273894: ConcurrentModificationException raised every time ReferralsCache drops referral #5632

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Sep 22, 2021

Can I please get a review for this change which proposes to fix the issue noted in https://bugs.openjdk.java.net/browse/JDK-8273894?

Given the nature of the code in ReferralsCache, I haven't been able to add a new jtreg test case to reproduce the issue and verify this fix. Just to be sure that this change indeed fixes a reproducible issue, I replicated that code in a pretty trivial Java application and then verified a similar fix.

Existing tests in test/jdk/sun/security/krb5/auto/ continue to pass after this change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273894: ConcurrentModificationException raised every time ReferralsCache drops referral

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5632/head:pull/5632
$ git checkout pull/5632

Update a local copy of the PR:
$ git checkout pull/5632
$ git pull https://git.openjdk.java.net/jdk pull/5632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5632

View PR using the GUI difftool:
$ git pr show -t 5632

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5632.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 22, 2021

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@jaikiran The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Sep 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 22, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

This seems to trace back all the way to initial integration with JDK-8215032. The bug and the fix are understandable. Looks good! @martinuy, who I think is the original author, should ack too.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273894: ConcurrentModificationException raised every time ReferralsCache drops referral

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 51085b5: 8274054: Add custom enqueue calls during reference processing
  • c77ebe8: 8274060: C2: Incorrect computation after JDK-8273454
  • d9872ba: 8273590: Move helper classes in G1 post evacuation sub tasks to cpp files
  • 688b3fe: 8274070: Rectify problemlist platform for failing test on macos12

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 22, 2021
@martinuy
Copy link
Contributor

@martinuy martinuy commented Sep 22, 2021

Hi,

Thanks for contributing this fix. I'm not an official Reviewer for JDK main line but your fix looks good to me.

Martin.-

@jaikiran
Copy link
Member Author

@jaikiran jaikiran commented Sep 23, 2021

Thank you Martin and Aleksey for the reviews.

@jaikiran
Copy link
Member Author

@jaikiran jaikiran commented Sep 23, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

Going to push as commit 2166ed1.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 1c6fa11: 8273979: move some os time related functions to os_posix for POSIX platforms
  • 45adc92: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
  • 0fbbe4c: 8274033: Some tier-4 CDS EpsilonGC tests throw OOM
  • 9d3379b: 8267356: AArch64: Vector API SVE codegen support
  • 6031388: 8273714: jdk/jfr/api/consumer/TestRecordedFrame.java still times out after JDK-8273047
  • 8821b00: 8205137: Remove Applet support from SwingSet2
  • 57fe11c: 8274120: [JVMCI] CompileBroker should resolve parameter types for JVMCI compiles
  • 81d4164: 8272759: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java failed in timeout
  • da38ced: 8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family
  • d39aad9: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/eeaf43b229941f49326ed6d0f37e77f6f0ce5409...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 23, 2021
@openjdk openjdk bot added integrated and removed ready labels Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@jaikiran Pushed as commit 2166ed1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 23, 2021
@jaikiran jaikiran deleted the 8273894 branch Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
3 participants