Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274900: Too weak variable type leads to unnecessary cast in jdk.javadoc #5636

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 22, 2021

There are several redundant casts, caused by fact, that related declared variable has too weak type.
We can change declaration type and remove redundant cast. It makes code more clear and easier to read.

Found by IntelliJ IDEA inspection 'Too weak variable type leads to unnecessary cast'


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274900: Too weak variable type leads to unnecessary cast in jdk.javadoc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5636/head:pull/5636
$ git checkout pull/5636

Update a local copy of the PR:
$ git checkout pull/5636
$ git pull https://git.openjdk.java.net/jdk pull/5636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5636

View PR using the GUI difftool:
$ git pr show -t 5636

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5636.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 22, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc label Sep 22, 2021
@turbanoff turbanoff changed the title [PATCH] Cleanup redundant casts, when type is actually known beforehand 8274900: Too weak variable type leads to unnecessary cast in jdk.javadoc Oct 7, 2021
@openjdk openjdk bot added the rfr label Oct 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 7, 2021

Webrevs

Copy link
Member

@pavelrappo pavelrappo left a comment

Looks good; thanks.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274900: Too weak variable type leads to unnecessary cast in jdk.javadoc

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 193 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@pavelrappo) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 7, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 8, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

@turbanoff
Your change (at version 095597a) is now ready to be sponsored by a Committer.

@pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Oct 8, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

Going to push as commit 9c431dd.
Since your change was applied there have been 200 commits pushed to the master branch:

  • 3cb9724: 8274934: Attempting to acquire lock JNICritical_lock/41 out of order with lock MultiArray_lock/41
  • 239a35a: 8233749: Files.exists javadoc doesn't mention eating IOException
  • ec19907: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile
  • ccbce10: 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop
  • 36b89a1: 8274785: ciReplay: Potential crash due to uninitialized Compile::_ilt variable
  • 2aacd42: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
  • 6364719: 8274004: Change 'nonleaf' rank name
  • b60837a: 8272586: emit abstract machine code in hs-err logs
  • 97ea9dd: 8274840: Update OS detection code to recognize Windows 11
  • 8de7763: 8273152: Refactor CDS FileMapHeader loading code
  • ... and 190 more: https://git.openjdk.java.net/jdk/compare/57fe11c9a37c121a244b3d6c9c0a1413dc0484b7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

@pavelrappo @turbanoff Pushed as commit 9c431dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the cleanup_redundant_casts_in_jdk.javadoc branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated javadoc
2 participants