Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274175: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java still failed in timeout #5642

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Sep 22, 2021

Test still fails in othervm mode; increase the timeout value.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274175: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java still failed in timeout

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5642/head:pull/5642
$ git checkout pull/5642

Update a local copy of the PR:
$ git checkout pull/5642
$ git pull https://git.openjdk.java.net/jdk pull/5642/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5642

View PR using the GUI difftool:
$ git pr show -t 5642

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5642.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 22, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio label Sep 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 22, 2021

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

I hope this is enough.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274175: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java still failed in timeout

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 2166ed1: 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral
  • 1c6fa11: 8273979: move some os time related functions to os_posix for POSIX platforms
  • 45adc92: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
  • 0fbbe4c: 8274033: Some tier-4 CDS EpsilonGC tests throw OOM
  • 9d3379b: 8267356: AArch64: Vector API SVE codegen support

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 23, 2021
@bplb
Copy link
Member Author

@bplb bplb commented Sep 23, 2021

I hope this is enough.

Likewise.

@bplb
Copy link
Member Author

@bplb bplb commented Sep 23, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

Going to push as commit 1fdc656.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 3b1b8fc: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • 1b7f4b7: 8274169: HotSpot Style Guide has stale link to chromium style guide
  • 653a612: 8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN
  • 66ce09f: 8272703: StressSeed should be set via FLAG_SET_ERGO
  • c434528: 8273546: DecimalFormat documentation contains literal HTML character references
  • d098751: 8273916: Remove 'special' ranking
  • 4f3b626: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions
  • 8799856: 8274075: Fix miscellaneous typos in java.base
  • 8b833bb: 8274048: IGV: Replace usages of Collections.sort with List.sort call
  • a74c099: 8252842: Extend jmap to support parallel heap dump
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/603138895f1665e75f01bb787af3222f08abc4db...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@bplb Pushed as commit 1fdc656.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the FileChannel-Transfer2GPlus-8274175 branch Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated nio
2 participants