Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274195: Doc cleanup in java.nio.file #5649

Closed
wants to merge 4 commits into from
Closed

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Sep 23, 2021

Please review this trivial change triggered by reading the java.nio.file documentation for an unrelated code review.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5649/head:pull/5649
$ git checkout pull/5649

Update a local copy of the PR:
$ git checkout pull/5649
$ git pull https://git.openjdk.java.net/jdk pull/5649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5649

View PR using the GUI difftool:
$ git pr show -t 5649

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5649.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 23, 2021

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@pavelrappo To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Conditionals in CONTINUE and SKIP_SIBLINGS could be worded similarly.
@pavelrappo
Copy link
Member Author

@pavelrappo pavelrappo commented Sep 23, 2021

/label nio

@openjdk openjdk bot added the nio label Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@pavelrappo
The nio label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 23, 2021

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Thanks for the limiting the changes in this update.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274195: Doc cleanup in java.nio.file

Reviewed-by: alanb, lancea, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 1fdc656: 8274175: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java still failed in timeout
  • 3b1b8fc: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • 1b7f4b7: 8274169: HotSpot Style Guide has stale link to chromium style guide
  • 653a612: 8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN
  • 66ce09f: 8272703: StressSeed should be set via FLAG_SET_ERGO
  • c434528: 8273546: DecimalFormat documentation contains literal HTML character references
  • d098751: 8273916: Remove 'special' ranking
  • 4f3b626: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions
  • 8799856: 8274075: Fix miscellaneous typos in java.base
  • 8b833bb: 8274048: IGV: Replace usages of Collections.sort with List.sort call
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/da38ced3299cbd02f210bea4130990a43f6104bf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 23, 2021
bplb
bplb approved these changes Sep 23, 2021
@pavelrappo
Copy link
Member Author

@pavelrappo pavelrappo commented Sep 23, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

Going to push as commit 5ffbe75.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 1fdc656: 8274175: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java still failed in timeout
  • 3b1b8fc: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • 1b7f4b7: 8274169: HotSpot Style Guide has stale link to chromium style guide
  • 653a612: 8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN
  • 66ce09f: 8272703: StressSeed should be set via FLAG_SET_ERGO
  • c434528: 8273546: DecimalFormat documentation contains literal HTML character references
  • d098751: 8273916: Remove 'special' ranking
  • 4f3b626: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions
  • 8799856: 8274075: Fix miscellaneous typos in java.base
  • 8b833bb: 8274048: IGV: Replace usages of Collections.sort with List.sort call
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/da38ced3299cbd02f210bea4130990a43f6104bf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@pavelrappo Pushed as commit 5ffbe75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated nio
4 participants