New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274195: Doc cleanup in java.nio.file #5649
Conversation
|
@pavelrappo To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
Conditionals in CONTINUE and SKIP_SIBLINGS could be worded similarly.
/label nio |
@pavelrappo |
Webrevs
|
This reverts commit b080d6d.
@pavelrappo This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
Going to push as commit 5ffbe75.
Your commit was automatically rebased without conflicts. |
@pavelrappo Pushed as commit 5ffbe75. |
Please review this trivial change triggered by reading the java.nio.file documentation for an unrelated code review.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5649/head:pull/5649
$ git checkout pull/5649
Update a local copy of the PR:
$ git checkout pull/5649
$ git pull https://git.openjdk.java.net/jdk pull/5649/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5649
View PR using the GUI difftool:
$ git pr show -t 5649
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5649.diff