New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8254195: java/nio/file/Files/SubstDrive.java failed with "AssertionError: expected [144951656448] but found [144951640064]" #565
Conversation
…onError: expected [144951656448] but found [144951640064]" Remove assertions for FileStore.getUnallocatedSpace() and FileStore.getUsableSpace() since the values are not guaranteed to be the same on a busy system.
👋 Welcome back nhat-nguyen! A progress list of the required criteria for merging this PR into |
@nhat-nguyen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@nhat-nguyen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @bplb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@nhat-nguyen |
/sponsor |
@AlanBateman @nhat-nguyen Pushed as commit 8c0d3d7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Remove assertions for FileStore.getUnallocatedSpace() and FileStore.getUsableSpace() since the values are not guaranteed to be the same on a busy system.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/565/head:pull/565
$ git checkout pull/565