Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8254195: java/nio/file/Files/SubstDrive.java failed with "AssertionError: expected [144951656448] but found [144951640064]" #565

Closed
wants to merge 1 commit into from

Conversation

@nhat-nguyen
Copy link
Contributor

@nhat-nguyen nhat-nguyen commented Oct 8, 2020

Remove assertions for FileStore.getUnallocatedSpace() and FileStore.getUsableSpace() since the values are not guaranteed to be the same on a busy system.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build (2/5 running) (2/2 running) (2/2 running)

Issue

  • JDK-8254195: java/nio/file/Files/SubstDrive.java failed with "AssertionError: expected [144951656448] but found [144951640064]"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/565/head:pull/565
$ git checkout pull/565

…onError: expected [144951656448] but found [144951640064]"

Remove assertions for FileStore.getUnallocatedSpace() and FileStore.getUsableSpace() since the values are not guaranteed to be the same on a busy system.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 8, 2020

👋 Welcome back nhat-nguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2020

@nhat-nguyen The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the nio label Oct 8, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 8, 2020

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2020

@nhat-nguyen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254195: java/nio/file/Files/SubstDrive.java failed with "AssertionError: expected [144951656448] but found [144951640064]"

Reviewed-by: alanb, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Oct 8, 2020
bplb
bplb approved these changes Oct 8, 2020
@nhat-nguyen
Copy link
Contributor Author

@nhat-nguyen nhat-nguyen commented Oct 8, 2020

/integrate

Loading

@openjdk openjdk bot added the sponsor label Oct 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2020

@nhat-nguyen
Your change (at version 509063b) is now ready to be sponsored by a Committer.

Loading

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Oct 8, 2020

/sponsor

Loading

@openjdk openjdk bot closed this Oct 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2020

@AlanBateman @nhat-nguyen Pushed as commit 8c0d3d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants