Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273618: DisplayChangeVITest.java is timing out on macOS 12 aarch64 #5653

Closed
wants to merge 2 commits into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Sep 23, 2021

java/awt/FullScreen/DisplayChangeVITest/DisplayChangeVITest.java is timing out on a macOS 12 aarch64 (an Apple Silicon Mac Mini) system due to getting locked on frame.dispose() even though test passed.
Modified test to use JFrame in EDT and revert the frame back to windowed mode before dispose frame in finally block.

Modified test pass in CI system for several iterations in all platforms (including macos x64 and aarch64)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273618: DisplayChangeVITest.java is timing out on macOS 12 aarch64

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5653/head:pull/5653
$ git checkout pull/5653

Update a local copy of the PR:
$ git checkout pull/5653
$ git pull https://git.openjdk.java.net/jdk pull/5653/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5653

View PR using the GUI difftool:
$ git pr show -t 5653

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5653.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 23, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the client label Sep 23, 2021
@openjdk openjdk bot added the rfr label Sep 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 23, 2021

Webrevs

Loading

@mrserb
Copy link
Member

@mrserb mrserb commented Sep 24, 2021

Does it mean that the app will hang if it tries to dispose of the full-screen window? Why does it is happening? The dispose machinery in the window class should handle this case:
DisposeAction{
....
if (gd.getFullScreenWindow() == Window.this) {
gd.setFullScreenWindow(null);
}

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 22, 2021

@prsadhuk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 19, 2021

@prsadhuk This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

Loading

@bridgekeeper bridgekeeper bot closed this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants