New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273682: Upgrade Jline to 3.20.0 #5655
Conversation
|
/** | ||
* | ||
* @param candidates list of candidates | ||
* @return a map of candidates that completion matcher matches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a list of ..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've filled:
jline/jline3#711
@@ -1,5 +1,5 @@ | |||
/* | |||
* Copyright (c) 2002-2016, the original author or authors. | |||
* Copyright (c) 2002-2020, the original author or authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2021
@lahodaj This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 711 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
Going to push as commit b8cb76a.
Your commit was automatically rebased without conflicts. |
I'd like to upgrade the internal JLine to 3.20.0, to support the rxvt terminal (see JDK-8270943), and to generally use a newer version of the library. This patch is basically a application of relevant parts of the diff between JLine 3.14.0 and 3.20.0, with merge fixes as needed.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5655/head:pull/5655
$ git checkout pull/5655
Update a local copy of the PR:
$ git checkout pull/5655
$ git pull https://git.openjdk.java.net/jdk pull/5655/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5655
View PR using the GUI difftool:
$ git pr show -t 5655
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5655.diff