-
Notifications
You must be signed in to change notification settings - Fork 6k
8274232: Cleanup unnecessary null comparison before instanceof check in jdk.jdi #5659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into |
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@plummercj, @sspitsyn) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks,
Serguei
/integrate |
@turbanoff |
@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
keep open |
Are you just waiting for a sponsor? |
Yep. |
/sponsor |
Going to push as commit db0c8d5.
Your commit was automatically rebased without conflicts. |
@plummercj @turbanoff Pushed as commit db0c8d5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Update code checks both non-null and instance of a class in jdk.jdi module classes.
The checks and explicit casts could also be replaced with pattern matching for the instanceof operator.
Similar cleanups
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5659/head:pull/5659
$ git checkout pull/5659
Update a local copy of the PR:
$ git checkout pull/5659
$ git pull https://git.openjdk.java.net/jdk pull/5659/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5659
View PR using the GUI difftool:
$ git pr show -t 5659
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5659.diff