Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails #5660

Closed
wants to merge 2 commits into from

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Sep 23, 2021

The test is being moved from the closed to open. It's nearly a complete re-write of the original test.

I made the test headless by painting into image.

To detect failure, the test uses the position of the caret at the end of first line of the paragraph where the wrapping occurs.

I made sure that the updated test reproduces the original problem in JDK-6318524. (There are some tweaks required to compile it with JDK 6.) The updated test fails when run with 6-b52. In fact, it also fails with 6-b53 up to 6-b76 where JDK-6364882 is fixed.

The behaviour in 6-b76 coincides with that in the latest JDK.

There are three parameters provided for debugging purposes:
-show: Show frame for visual inspection
-save: Save the start image after the first paragraph is justified, and the last image before it's checked that the first paragraph remains justified
-saveAll: Save images for all the intermediate steps

[1] JDK-6318524: Regression: views in paragraph are not children of Paragraph.Row is some cases
[2] JDK-6364882: Last line of a paragraph should not be justified


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5660/head:pull/5660
$ git checkout pull/5660

Update a local copy of the PR:
$ git checkout pull/5660
$ git pull https://git.openjdk.java.net/jdk pull/5660/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5660

View PR using the GUI difftool:
$ git pr show -t 5660

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5660.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2021

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2021
@openjdk
Copy link

openjdk bot commented Sep 23, 2021

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 23, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2021

Webrevs

mrserb
mrserb approved these changes Sep 23, 2021
@openjdk
Copy link

openjdk bot commented Sep 23, 2021

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2021
@prsadhuk
Copy link
Contributor

Probably it will be better to use descriptive name for the test rather than bugid. Probably it was done to maintain consistency with closed test but since it is supposedly a rewrite and we have done away with bugid in testname, a descriptive name will be better. Also @bug tag will let us know for which it was written..

@aivanov-jdk
Copy link
Member Author

Probably it will be better to use descriptive name for the test rather than bugid.

In the majority of cases, the test name is not detailed enough, however, it usually gives a better idea than a plain bugid. If a test fails, you still have to analyse it.

Probably it was done to maintain consistency with closed test but since it is supposedly a rewrite and we have done away with bugid in testname, a descriptive name will be better. Also @bug tag will let us know for which it was written..

Even if it's completely re-written, it's not a new test. I'd rather keep the original name: searching for it returns some bugs; if the test name is changed, those search results are lost.

@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

Going to push as commit b7425b6.
Since your change was applied there have been 52 commits pushed to the master branch:

  • c57a6c6: 8274265: Suspicious string concatenation in logTestUtils.inline.hpp
  • 6f4cefb: 8274394: Use Optional.isEmpty instead of !Optional.isPresent in jdk.jlink
  • 94f5e80: 8274276: Cache normalizedBase URL in URLClassPath.FileLoader
  • b36881f: 8274383: JNI call of getAccessibleSelection on a wrong thread
  • be40373: 8274381: missing CAccessibility definitions in JNI code
  • 79865cd: 8274259: G1: assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe after JDK-8270009
  • 961dcff: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class
  • 6a573b8: 8273508: Support archived heap objects in SerialGC
  • 3eca9c3: 8264707: HotSpot Style Guide should permit use of lambda
  • af50772: 8231640: (prop) Canonical property storage
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/0aa63feca8704c8958530ef9e3df128570c50e12...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@aivanov-jdk Pushed as commit b7425b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the JDK-8239502 branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants