Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8274087: Windows DLL path not set correctly. #5663

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -139,8 +139,6 @@ void launchApp() {
const tstring launcherPath = SysInfo::getProcessModulePath();
const tstring appImageRoot = FileUtils::dirname(launcherPath);
const tstring appDirPath = FileUtils::mkpath() << appImageRoot << _T("app");
const tstring runtimeBinPath = FileUtils::mkpath()
<< appImageRoot << _T("runtime") << _T("bin");

const AppLauncher appLauncher = AppLauncher().setImageRoot(appImageRoot)
.addJvmLibName(_T("bin\\jli.dll"))
@@ -188,9 +186,11 @@ void launchApp() {
return;
}

// zip.dll may be loaded by java without full path
// zip.dll (and others) may be loaded by java without full path
// make sure it will look in runtime/bin
const tstring runtimeBinPath = FileUtils::dirname(jvm->getPath());
SetDllDirectory(runtimeBinPath.c_str());
LOG_TRACE(tstrings::any() << "SetDllDirectory to: " << runtimeBinPath);

const DllWrapper jliDll(jvm->getPath());
std::unique_ptr<DllWrapper> splashDll;