Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8274259: G1: assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe after JDK-8270009 #5672

Closed
wants to merge 2 commits into from

Conversation

tbzhang
Copy link
Contributor

@tbzhang tbzhang commented Sep 24, 2021

After JDK-8270009, the VerifyBeforeGC missed retired tlabs before verify remset


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274259: G1: assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe after JDK-8270009

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5672/head:pull/5672
$ git checkout pull/5672

Update a local copy of the PR:
$ git checkout pull/5672
$ git pull https://git.openjdk.java.net/jdk pull/5672/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5672

View PR using the GUI difftool:
$ git pr show -t 5672

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5672.diff

…aligned: 0x00000008baadbabe after JDK-8270009
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 24, 2021

👋 Welcome back tbzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@tbzhang The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Sep 24, 2021
@openjdk openjdk bot added the rfr label Sep 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 24, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm. Thanks.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@tbzhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274259: G1: assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe after JDK-8270009

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 7436a77: 8274317: Unnecessary reentrant synchronized block in java.awt.Cursor
  • 7426fd4: 8274325: C4819 warning at vm_version_x86.cpp on Windows after JDK-8234160
  • e3aff8f: 8274289: jdk/jfr/api/consumer/TestRecordedFrameType.java failed with "RuntimeException: assertNotEquals: expected Interpreted to not equal Interpreted"
  • 252aaa9: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 7700b25: 8273401: Disable JarIndex support in URLClassPath
  • 5ec1cdc: 8274321: Standardize values of @SInCE tags in javax.lang.model
  • 4838a2c: 8274143: Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty
  • ab28db1: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
  • 8c122af: 8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc
  • 9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/56b8b35286634f2d2224ca445bc9f32ff284ae74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kstefanj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 24, 2021
@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Sep 24, 2021

Fwiw, for other reviewers, (I think) the cause is the move of the ensure_parsability call from gc_prologue into pre_evacuate_collection_set that always occurs after verification.

@tbzhang
Copy link
Contributor Author

@tbzhang tbzhang commented Sep 24, 2021

Lgtm. Thanks.

Thanks for your review!

Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

@tbzhang
Copy link
Contributor Author

@tbzhang tbzhang commented Sep 27, 2021

Looks good.

Thanks for your review!

@tbzhang
Copy link
Contributor Author

@tbzhang tbzhang commented Sep 27, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

@tbzhang
Your change (at version 45e6ea3) is now ready to be sponsored by a Committer.

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Sep 28, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

Going to push as commit 79865cd.
Since your change was applied there have been 45 commits pushed to the master branch:

  • 961dcff: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class
  • 6a573b8: 8273508: Support archived heap objects in SerialGC
  • 3eca9c3: 8264707: HotSpot Style Guide should permit use of lambda
  • af50772: 8231640: (prop) Canonical property storage
  • ddc2627: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem
  • 633eab2: 8174819: java/nio/file/WatchService/LotsOfEvents.java fails intermittently
  • 8876eae: 8269685: Optimize HeapHprofBinWriter implementation
  • c880b87: 8274367: Re-indent stack-trace examples for Throwable.printStackTrace
  • c4b52c7: 8271303: jcmd VM.cds {static, dynamic}_dump should print more info
  • 5b660f3: 8274392: Suppress more warnings on non-serializable non-transient instance fields in java.sql.rowset
  • ... and 35 more: https://git.openjdk.java.net/jdk/compare/56b8b35286634f2d2224ca445bc9f32ff284ae74...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@tschatzl @tbzhang Pushed as commit 79865cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants