Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274143 Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty #5674

Closed
wants to merge 1 commit into from

Conversation

@djelinski
Copy link
Contributor

@djelinski djelinski commented Sep 24, 2021

The default list of providers defined in java.security file can be overridden with a custom file, declared with -Djava.security.properties=/path/to/custom.security command line parameter.
If the new list of providers is shorter than the original one, it is necessary to add an empty entry to terminate the list, like:

security.provider.1=BCFIPS C:HYBRID;ENABLE{All}
security.provider.2=SUN
security.provider.3=BCJSSE fips:BCFIPS
security.provider.4=

otherwise some providers from the default list will still be used.

Currently Java outputs an error message on standard error when it encounters an empty entry on the provider list. This PR silences that message.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274143: Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5674/head:pull/5674
$ git checkout pull/5674

Update a local copy of the PR:
$ git checkout pull/5674
$ git pull https://git.openjdk.java.net/jdk pull/5674/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5674

View PR using the GUI difftool:
$ git pr show -t 5674

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5674.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 24, 2021

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@djelinski The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the security label Sep 24, 2021
@djelinski djelinski marked this pull request as ready for review Sep 24, 2021
@openjdk openjdk bot added the rfr label Sep 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 24, 2021

Webrevs

Loading

Copy link
Contributor

@wangweij wangweij left a comment

Changes looks fine. I've also added a noreg-trivial label to the JBS bug.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

⚠️ @djelinski the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout silence-warning
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274143: Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • f214d6e: 8274234: Remove unnecessary boxing via primitive wrapper valueOf(String) methods in java.sql.rowset
  • f36a2bb: 8274087: Windows DLL path not set correctly.
  • 5ba0d09: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC
  • 5a12af7: 8271880: Tighten condition for excluding regions from collecting cards with cross-references
  • db23ecd: 8274191: Improve g1 evacuation failure injector performance
  • d91e227: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
  • 971aa35: 8274083: Update testing docs to mention tiered testing
  • 1d44014: 8273034: Make javadoc navigation collapsible on small displays
  • bb74ae8: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Sep 24, 2021
@djelinski
Copy link
Contributor Author

@djelinski djelinski commented Sep 24, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Sep 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@djelinski
Your change (at version 58ca4e0) is now ready to be sponsored by a Committer.

Loading

@djelinski
Copy link
Contributor Author

@djelinski djelinski commented Sep 25, 2021

Thank you @wangweij for the review and JBS changes. Could you sponsor this patch?

Loading

@wangweij
Copy link
Contributor

@wangweij wangweij commented Sep 25, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

Going to push as commit 4838a2c.
Since your change was applied there have been 21 commits pushed to the master branch:

  • ab28db1: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
  • 8c122af: 8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc
  • 9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare
  • 5756385: 8274273: Update testing docs for MacOS with Non-US locale
  • 61ac53f: 8210927: JDB tests do not update source path after doing a redefine class
  • 341de49: 8273492: Move evacuation failure handling into G1YoungCollector
  • 13e9ea9: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125
  • 753b256: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS
  • baafa60: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base
  • 0c050be: 8274294: ProblemList sun/tools/jmap/BasicJMapTest.java
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/56b8b35286634f2d2224ca445bc9f32ff284ae74...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@wangweij @djelinski Pushed as commit 4838a2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants