Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274273: Update testing docs for MacOS with Non-US locale #5676

Closed
wants to merge 2 commits into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Sep 24, 2021

Hi all,

I'd like to update the testing docs for MacOS with Non-US locale.

Our experiments show that the solution mentioned for Windows with Non-US locale also works for MacOS.
So it would be helpful to mention MacOS explicitly.

FYI: changes in doc/testing.html was made by make update-build-docs .

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274273: Update testing docs for MacOS with Non-US locale

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5676/head:pull/5676
$ git checkout pull/5676

Update a local copy of the PR:
$ git checkout pull/5676
$ git pull https://git.openjdk.java.net/jdk pull/5676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5676

View PR using the GUI difftool:
$ git pr show -t 5676

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5676.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 24, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@DamonFool The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Sep 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 24, 2021

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

The actual change is ok, but it seems your version of pandoc is creating a lot of spurious changes throughout the html version. Since this change is so small, maybe you could just manually revert everything but the actual text addition you are making in that file?

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Sep 24, 2021

The actual change is ok, but it seems your version of pandoc is creating a lot of spurious changes throughout the html version. Since this change is so small, maybe you could just manually revert everything but the actual text addition you are making in that file?

Thanks @erikj79 for your review.
Updated.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274273: Update testing docs for MacOS with Non-US locale

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • f36a2bb: 8274087: Windows DLL path not set correctly.
  • 5ba0d09: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC
  • 5a12af7: 8271880: Tighten condition for excluding regions from collecting cards with cross-references
  • db23ecd: 8274191: Improve g1 evacuation failure injector performance
  • d91e227: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 24, 2021
@mrserb
Copy link
Member

@mrserb mrserb commented Sep 24, 2021

Can you please take a look at this review request which actually fixes this problem?
#5098

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Sep 24, 2021

Can you please take a look at this review request which actually fixes this problem?
#5098

Sure.
Will test your patch and let you know tomorrow.
Thanks.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

Going to push as commit 5756385.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 61ac53f: 8210927: JDB tests do not update source path after doing a redefine class
  • 341de49: 8273492: Move evacuation failure handling into G1YoungCollector
  • 13e9ea9: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125
  • 753b256: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS
  • baafa60: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base
  • 0c050be: 8274294: ProblemList sun/tools/jmap/BasicJMapTest.java
  • e741a18: 8274233: Minor cleanup for ToolBox
  • 718eff2: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
  • f214d6e: 8274234: Remove unnecessary boxing via primitive wrapper valueOf(String) methods in java.sql.rowset
  • f36a2bb: 8274087: Windows DLL path not set correctly.
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/971aa353aae51222ca33ebfdd61b91672a6c871a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@DamonFool Pushed as commit 5756385.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8274273 branch Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
3 participants