8273410: IR verification framework fails with "Should find method name in validIrRulesMap" #5678

chhagedorn · 2021-09-24T10:36:34Z

The IR framework treated a @Check method as @Test method instead of the @Test method itself at IR matching time resulting in an internal framework exception.

While writing some tests for checked test I've noticed that a missing @Arguments annotation is not reported as TestFormatException but with a RuntimeException later when invoking the method in question. I also added the missing check for it.

Thanks,
Christian

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8273410: IR verification framework fails with "Should find method name in validIrRulesMap"

Reviewers

Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to e2a5d83
Nils Eliasson (@neliasso - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5678/head:pull/5678
$ git checkout pull/5678

Update a local copy of the PR:
$ git checkout pull/5678
$ git pull https://git.openjdk.java.net/jdk pull/5678/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5678

View PR using the GUI difftool:
$ git pr show -t 5678

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5678.diff

…e in validIrRulesMap"

bridgekeeper · 2021-09-24T10:37:55Z

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-09-24T10:41:54Z

@chhagedorn The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-09-24T10:46:16Z

Webrevs

01: Full - Incremental (ae88dcfa)
00: Full (e2a5d83e)

TobiHartmann

Looks good to me.

TobiHartmann · 2021-09-27T06:09:59Z

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java

+        }
+    }
+
+


Double newline.

TobiHartmann · 2021-09-27T06:10:16Z

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java

+
+/*
+ * @test
+ * @requires vm.debug == true & vm.compMode != "Xint" & vm.compiler2.enabled & vm.flagless


You might want to add an @bug tag.

chhagedorn · 2021-09-27T07:38:20Z

Thanks Tobias for your review!

openjdk · 2021-09-27T09:17:40Z

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273410: IR verification framework fails with "Should find method name in validIrRulesMap"

Reviewed-by: thartmann, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 254 new commits pushed to the master branch:

2faced0: 8274738: ZGC: Use relaxed atomic load when reading bits in the live map
8a4d2b4: 8274680: Remove unnecessary conversion to String in java.desktop
986ee5d: 8274670: Improve version string handling in SA
df7b0c7: 8274715: Implement forEach in Collections.CopiesList
d4e8712: 8274797: ProblemList resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java on macosx-x64
4726267: 8274642: jdk/jshell/CommandCompletionTest.java fails with NoSuchElementException after JDK-8271287
83b2219: 8273612: Fix for JDK-8272873 causes timeout in running some tests with -Xcomp
d34ec6c: 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net
332f067: 8274729: Define Position.NOPOS == Diagnostic.NOPOS
1e75203: 8274656: Remove default_checksum and safe_checksum_type from krb5.conf
... and 244 more: https://git.openjdk.java.net/jdk/compare/74ffe12267cb3ae63072a06f50083fd0352d8049...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

chhagedorn · 2021-10-06T07:20:33Z

Anyone for a second review?

neliasso

Looks good!

chhagedorn · 2021-10-06T08:19:39Z

Thanks Nils for your review!

chhagedorn · 2021-10-06T08:20:21Z

/integrate

openjdk · 2021-10-06T08:21:31Z

Going to push as commit df125f6.
Since your change was applied there have been 255 commits pushed to the master branch:

c74726d: 8274730: AArch64: AES/GCM acceleration is broken by the fix for JDK-8273297
2faced0: 8274738: ZGC: Use relaxed atomic load when reading bits in the live map
8a4d2b4: 8274680: Remove unnecessary conversion to String in java.desktop
986ee5d: 8274670: Improve version string handling in SA
df7b0c7: 8274715: Implement forEach in Collections.CopiesList
d4e8712: 8274797: ProblemList resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java on macosx-x64
4726267: 8274642: jdk/jshell/CommandCompletionTest.java fails with NoSuchElementException after JDK-8271287
83b2219: 8273612: Fix for JDK-8272873 causes timeout in running some tests with -Xcomp
d34ec6c: 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net
332f067: 8274729: Define Position.NOPOS == Diagnostic.NOPOS
... and 245 more: https://git.openjdk.java.net/jdk/compare/74ffe12267cb3ae63072a06f50083fd0352d8049...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-10-06T08:21:46Z

@chhagedorn Pushed as commit df125f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8273410: IR verification framework fails with "Should find method nam…

e2a5d83

…e in validIrRulesMap"

openjdk bot added the rfr Pull request is ready for review label Sep 24, 2021

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 24, 2021

TobiHartmann approved these changes Sep 27, 2021

View reviewed changes

Add @bug

ae88dcf

openjdk bot added the ready Pull request is ready to be integrated label Sep 27, 2021

neliasso approved these changes Oct 6, 2021

View reviewed changes

openjdk bot closed this Oct 6, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2021

chhagedorn deleted the JDK-8273410 branch April 5, 2023 08:07

8273410: IR verification framework fails with "Should find method name in validIrRulesMap" #5678

8273410: IR verification framework fails with "Should find method name in validIrRulesMap" #5678

chhagedorn commented Sep 24, 2021 •

edited by openjdk bot

bridgekeeper bot commented Sep 24, 2021

openjdk bot commented Sep 24, 2021

mlbridge bot commented Sep 24, 2021 •

edited

TobiHartmann left a comment

TobiHartmann Sep 27, 2021

TobiHartmann Sep 27, 2021

chhagedorn commented Sep 27, 2021

openjdk bot commented Sep 27, 2021 •

edited

chhagedorn commented Oct 6, 2021

neliasso left a comment

chhagedorn commented Oct 6, 2021

chhagedorn commented Oct 6, 2021

openjdk bot commented Oct 6, 2021

openjdk bot commented Oct 6, 2021

8273410: IR verification framework fails with "Should find method name in validIrRulesMap" #5678

8273410: IR verification framework fails with "Should find method name in validIrRulesMap" #5678

Conversation

chhagedorn commented Sep 24, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 24, 2021

openjdk bot commented Sep 24, 2021

mlbridge bot commented Sep 24, 2021 • edited

Webrevs

TobiHartmann left a comment

Choose a reason for hiding this comment

TobiHartmann Sep 27, 2021

Choose a reason for hiding this comment

TobiHartmann Sep 27, 2021

Choose a reason for hiding this comment

chhagedorn commented Sep 27, 2021

openjdk bot commented Sep 27, 2021 • edited

chhagedorn commented Oct 6, 2021

neliasso left a comment

Choose a reason for hiding this comment

chhagedorn commented Oct 6, 2021

chhagedorn commented Oct 6, 2021

openjdk bot commented Oct 6, 2021

openjdk bot commented Oct 6, 2021

chhagedorn commented Sep 24, 2021 •

edited by openjdk bot

mlbridge bot commented Sep 24, 2021 •

edited

openjdk bot commented Sep 27, 2021 •

edited