Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274294: ProblemList sun/tools/jmap/BasicJMapTest.java #5685

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Sep 24, 2021

A trivial fix to ProblemList sun/tools/jmap/BasicJMapTest.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274294: ProblemList sun/tools/jmap/BasicJMapTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5685/head:pull/5685
$ git checkout pull/5685

Update a local copy of the PR:
$ git checkout pull/5685
$ git pull https://git.openjdk.java.net/jdk pull/5685/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5685

View PR using the GUI difftool:
$ git pr show -t 5685

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5685.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Sep 24, 2021

/label add hotspot-runtime
/label add serviceability

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Sep 24, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 24, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274294: ProblemList sun/tools/jmap/BasicJMapTest.java

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e741a18: 8274233: Minor cleanup for ToolBox
  • 718eff2: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 24, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Sep 24, 2021

@RogerRiggs - Thanks for the fast review!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added hotspot-runtime serviceability labels Sep 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

Going to push as commit 0c050be.
Since your change was applied there have been 2 commits pushed to the master branch:

  • e741a18: 8274233: Minor cleanup for ToolBox
  • 718eff2: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@dcubed-ojdk Pushed as commit 0c050be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 24, 2021

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8274294 branch Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated serviceability
2 participants