8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated #5686

xpbob · 2021-09-24T16:18:57Z

remove vfork() on Darwin

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated

Reviewers

Alan Bateman (@AlanBateman - Reviewer)
Thomas Stuefe (@tstuefe - Reviewer)
Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5686/head:pull/5686
$ git checkout pull/5686

Update a local copy of the PR:
$ git checkout pull/5686
$ git pull https://git.openjdk.java.net/jdk pull/5686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5686

View PR using the GUI difftool:
$ git pr show -t 5686

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5686.diff

bridgekeeper · 2021-09-24T16:19:37Z

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-09-24T16:21:44Z

@xpbob The following labels will be automatically applied to this pull request:

core-libs
hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-09-24T16:27:13Z

Webrevs

01: Full - Incremental (27d19543)
00: Full (89bb9c31)

src/java.base/unix/native/libjava/ProcessImpl_md.c

AlanBateman

I think this looks okay but would be good for @RogerRiggs to also review.

openjdk · 2021-09-25T08:37:39Z

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated

Reviewed-by: alanb, stuefe, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

5ec1cdc: 8274321: Standardize values of @SInCE tags in javax.lang.model
4838a2c: 8274143: Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty
ab28db1: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
8c122af: 8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc
9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare
5756385: 8274273: Update testing docs for MacOS with Non-US locale
61ac53f: 8210927: JDB tests do not update source path after doing a redefine class
341de49: 8273492: Move evacuation failure handling into G1YoungCollector
13e9ea9: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125
753b256: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS
... and 13 more: https://git.openjdk.java.net/jdk/compare/56b8b35286634f2d2224ca445bc9f32ff284ae74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @tstuefe, @RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

tstuefe

The JDK change is fine. AFAICS we have used posix_spawn by default on MacOS since at least 2015, and vfork was not even an option on MacOS.

Wrt the hotspot portion, we now fall back to fork. I wonder what the footprint penalty is compared to vfork. os::fork_and_exec gets used mainly by error reporting (-XX:OnError=xxx), e.g. in OOM situations. We now may run into situations where error analysis tools are unable to spawn if the parent is too big. Maybe we should change os::fork_and_exec() to use posix_spawn instead?

tstuefe

.. I opened https://bugs.openjdk.java.net/browse/JDK-8274320 to track the proposed change of os::fork_and_exec() to posix_spawn. So I am fine with this change.

xpbob · 2021-09-26T01:13:46Z

/integrate

RogerRiggs

Looks good, vfork is not/was not being used on Mac OS.

DamonFool · 2021-09-26T01:17:36Z

/sponsor

openjdk · 2021-09-26T04:12:25Z

@xpbob
Your change (at version 27d1954) is now ready to be sponsored by a Committer.

DamonFool · 2021-09-26T08:44:09Z

/sponsor

openjdk · 2021-09-26T14:48:28Z

Going to push as commit 252aaa9.
Since your change was applied there have been 24 commits pushed to the master branch:

7700b25: 8273401: Disable JarIndex support in URLClassPath
5ec1cdc: 8274321: Standardize values of @SInCE tags in javax.lang.model
4838a2c: 8274143: Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty
ab28db1: 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
8c122af: 8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc
9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare
5756385: 8274273: Update testing docs for MacOS with Non-US locale
61ac53f: 8210927: JDB tests do not update source path after doing a redefine class
341de49: 8273492: Move evacuation failure handling into G1YoungCollector
13e9ea9: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125
... and 14 more: https://git.openjdk.java.net/jdk/compare/56b8b35286634f2d2224ca445bc9f32ff284ae74...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-09-26T14:48:43Z

@DamonFool @xpbob Pushed as commit 252aaa9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk · 2021-09-27T02:10:55Z

@DamonFool The command sponsor can only be used in open pull requests.

8274293: Build failure with Xcode 13.0 due to vfork is deprecated

89bb9c3

openjdk bot added the rfr Pull request is ready for review label Sep 24, 2021

openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Sep 24, 2021

AlanBateman reviewed Sep 24, 2021

View reviewed changes

src/java.base/unix/native/libjava/ProcessImpl_md.c Outdated Show resolved Hide resolved

Drop drop "Solaris" from the comment

27d1954

xpbob changed the title ~~8274293: Build failure with Xcode 13.0 due to vfork is deprecated~~ JDK-8274293: [macos] Build failure with Xcode 13.0 due to vfork is deprecated Sep 25, 2021

xpbob changed the title ~~JDK-8274293: [macos] Build failure with Xcode 13.0 due to vfork is deprecated~~ 8274293: [macos] Build failure with Xcode 13.0 due to vfork is deprecated Sep 25, 2021

AlanBateman approved these changes Sep 25, 2021

View reviewed changes

xpbob changed the title ~~8274293: [macos] Build failure with Xcode 13.0 due to vfork is deprecated~~ 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated Sep 25, 2021

openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2021

tstuefe reviewed Sep 25, 2021

View reviewed changes

tstuefe approved these changes Sep 25, 2021

View reviewed changes

RogerRiggs approved these changes Sep 26, 2021

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 26, 2021

openjdk bot closed this Sep 26, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated #5686

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated #5686

xpbob commented Sep 24, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 24, 2021

openjdk bot commented Sep 24, 2021

mlbridge bot commented Sep 24, 2021 •

edited

Loading

AlanBateman left a comment

openjdk bot commented Sep 25, 2021 •

edited

Loading

tstuefe left a comment •

edited

Loading

tstuefe left a comment

xpbob commented Sep 26, 2021

RogerRiggs left a comment

DamonFool commented Sep 26, 2021

openjdk bot commented Sep 26, 2021

DamonFool commented Sep 26, 2021

openjdk bot commented Sep 26, 2021

openjdk bot commented Sep 26, 2021

openjdk bot commented Sep 27, 2021

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated #5686

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated #5686

Conversation

xpbob commented Sep 24, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 24, 2021

openjdk bot commented Sep 24, 2021

mlbridge bot commented Sep 24, 2021 • edited Loading

Webrevs

AlanBateman left a comment

Choose a reason for hiding this comment

openjdk bot commented Sep 25, 2021 • edited Loading

tstuefe left a comment • edited Loading

Choose a reason for hiding this comment

tstuefe left a comment

Choose a reason for hiding this comment

xpbob commented Sep 26, 2021

RogerRiggs left a comment

Choose a reason for hiding this comment

DamonFool commented Sep 26, 2021

openjdk bot commented Sep 26, 2021

DamonFool commented Sep 26, 2021

openjdk bot commented Sep 26, 2021

openjdk bot commented Sep 26, 2021

openjdk bot commented Sep 27, 2021

xpbob commented Sep 24, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 24, 2021 •

edited

Loading

openjdk bot commented Sep 25, 2021 •

edited

Loading

tstuefe left a comment •

edited

Loading