Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274296: Update or Problem List tests which may fail with uiScale=2 on macOS #5687

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Sep 24, 2021

As described in https://bugs.openjdk.java.net/browse/JDK-8274106 a number of tests fail due to some inaccuracy in pixels copied from the screen when scaling down from device space to user space.
The subject of most of these tests is such that uiScale isn't important and we can have them pass with -Dsun.java2d.uiScale=1.
For the rest we can problem list them - as narrowly as we can on macos-aarch64 which is the only place we've seen the problem (not happening on retina displays with x64 it seems) whilst we try to figure out the root cause which is either in Apple code or something we are doing to trigger that Apple API misbehaviour.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274296: Update or Problem List tests which may fail with uiScale=2 on macOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5687/head:pull/5687
$ git checkout pull/5687

Update a local copy of the PR:
$ git checkout pull/5687
$ git pull https://git.openjdk.java.net/jdk pull/5687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5687

View PR using the GUI difftool:
$ git pr show -t 5687

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5687.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 24, 2021
@openjdk
Copy link

openjdk bot commented Sep 24, 2021

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 24, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 24, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274296: Update or Problem List tests which may fail with uiScale=2 on macOS

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • baafa60: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base
  • 0c050be: 8274294: ProblemList sun/tools/jmap/BasicJMapTest.java
  • e741a18: 8274233: Minor cleanup for ToolBox
  • 718eff2: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
  • f214d6e: 8274234: Remove unnecessary boxing via primitive wrapper valueOf(String) methods in java.sql.rowset
  • f36a2bb: 8274087: Windows DLL path not set correctly.
  • 5ba0d09: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC
  • 5a12af7: 8271880: Tighten condition for excluding regions from collecting cards with cross-references
  • db23ecd: 8274191: Improve g1 evacuation failure injector performance
  • d91e227: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/0aa63feca8704c8958530ef9e3df128570c50e12...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 24, 2021
@prrace
Copy link
Contributor Author

prrace commented Sep 24, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 24, 2021

Going to push as commit 753b256.
Since your change was applied there have been 14 commits pushed to the master branch:

  • baafa60: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base
  • 0c050be: 8274294: ProblemList sun/tools/jmap/BasicJMapTest.java
  • e741a18: 8274233: Minor cleanup for ToolBox
  • 718eff2: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
  • f214d6e: 8274234: Remove unnecessary boxing via primitive wrapper valueOf(String) methods in java.sql.rowset
  • f36a2bb: 8274087: Windows DLL path not set correctly.
  • 5ba0d09: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC
  • 5a12af7: 8271880: Tighten condition for excluding regions from collecting cards with cross-references
  • db23ecd: 8274191: Improve g1 evacuation failure injector performance
  • d91e227: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/0aa63feca8704c8958530ef9e3df128570c50e12...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 24, 2021
@openjdk
Copy link

openjdk bot commented Sep 24, 2021

@prrace Pushed as commit 753b256.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 24, 2021
@@ -26,7 +26,7 @@
* @bug 8190230 8196360
* @summary [macosx] Order of overlapping of modal dialogs is wrong
* @key headful
* @run main SiblingChildOrderTest
* @run main/othervm -Dsun.java2d.uiScale=1 SiblingChildOrderTest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching this tests to scale=1 seems completely wrong. On macos it just tweak the rendering so that bug became invisible due to lost of precision. And now we will run the tests in lowDPI on all other platforms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If really needed I can file a follow-on to change this test to problem listed on macOS like some of the others .. but this test doesn't look to me like its a pixel precision test ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants