-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274296: Update or Problem List tests which may fail with uiScale=2 on macOS #5687
Conversation
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 753b256.
Your commit was automatically rebased without conflicts. |
@@ -26,7 +26,7 @@ | |||
* @bug 8190230 8196360 | |||
* @summary [macosx] Order of overlapping of modal dialogs is wrong | |||
* @key headful | |||
* @run main SiblingChildOrderTest | |||
* @run main/othervm -Dsun.java2d.uiScale=1 SiblingChildOrderTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching this tests to scale=1 seems completely wrong. On macos it just tweak the rendering so that bug became invisible due to lost of precision. And now we will run the tests in lowDPI on all other platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If really needed I can file a follow-on to change this test to problem listed on macOS like some of the others .. but this test doesn't look to me like its a pixel precision test ...
As described in https://bugs.openjdk.java.net/browse/JDK-8274106 a number of tests fail due to some inaccuracy in pixels copied from the screen when scaling down from device space to user space.
The subject of most of these tests is such that uiScale isn't important and we can have them pass with -Dsun.java2d.uiScale=1.
For the rest we can problem list them - as narrowly as we can on macos-aarch64 which is the only place we've seen the problem (not happening on retina displays with x64 it seems) whilst we try to figure out the root cause which is either in Apple code or something we are doing to trigger that Apple API misbehaviour.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5687/head:pull/5687
$ git checkout pull/5687
Update a local copy of the PR:
$ git checkout pull/5687
$ git pull https://git.openjdk.java.net/jdk pull/5687/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5687
View PR using the GUI difftool:
$ git pr show -t 5687
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5687.diff