-
Notifications
You must be signed in to change notification settings - Fork 6k
JDK-8274311: Make build.tools.jigsaw.GenGraphs more configurable #5690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mchung! A progress list of the required criteria for merging this PR into |
@mlchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit daaa47e.
Your commit was automatically rebased without conflicts. |
GenGraphs tool generates the module graph. It currently supports the configuration via javadoc-graphs.properties. However,
make/jdk/src/classes/build/tools/jigsaw/javadoc-graphs.properties
only documents two properties. It should be updated to cover all configurable properties.There are a couple other properties not configurable such as nodesep and node margin. This extends the configuration to allow to set additional properties.
This also fixes
requiresMandatedColor
in javadoc-graphs.properties to light gray to match the default configuration in the implementation, i.e. the color of the edge to java.base. It seems a bug that was unnoticed until Alex and Iris spotted it.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5690/head:pull/5690
$ git checkout pull/5690
Update a local copy of the PR:
$ git checkout pull/5690
$ git pull https://git.openjdk.java.net/jdk pull/5690/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5690
View PR using the GUI difftool:
$ git pr show -t 5690
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5690.diff