Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all #5691

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Sep 25, 2021

A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on macOS-all.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
  • JDK-8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5691/head:pull/5691
$ git checkout pull/5691

Update a local copy of the PR:
$ git checkout pull/5691
$ git pull https://git.openjdk.java.net/jdk pull/5691/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5691

View PR using the GUI difftool:
$ git pr show -t 5691

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5691.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Sep 25, 2021

/label add hotspot-runtime
/label add serviceability

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Sep 25, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 25, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr hotspot-runtime labels Sep 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability label Sep 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 25, 2021

Webrevs

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Sep 25, 2021

/issue JDK-8274312
/issue JDK-8274313

@openjdk openjdk bot changed the title 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macOS-all 8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all Sep 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests.

Copy link
Member

@tstuefe tstuefe left a comment

Looks good and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests

Reviewed-by: stuefe, sspitsyn, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 25, 2021
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Looks good.
Thanks,
Serguei

sun/tools/jmap/BasicJMapTest.java#G1 8274245 generic-all
sun/tools/jmap/BasicJMapTest.java#Parallel 8274245 generic-all
sun/tools/jmap/BasicJMapTest.java#Serial 8274245 generic-all
sun/tools/jmap/BasicJMapTest.java#Z 8274245 generic-all
Copy link
Member

@dholmes-ora dholmes-ora Sep 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think it was necessary to enumerate subtests like this?

Copy link
Member Author

@dcubed-ojdk dcubed-ojdk Sep 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think so either, but the original ProblemListing bug:

JDK-8274294 ProblemList sun/tools/jmap/BasicJMapTest.java

didn't do the job.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Sep 25, 2021

@tstuefe, @sspitsyn and @dholmes-ora - Thanks for the reviews!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

Going to push as commit ab28db1.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8c122af: 8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc
  • 9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2021

@dcubed-ojdk Pushed as commit ab28db1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8274312 branch Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated serviceability
4 participants