8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all

[dcubed-ojdk]

A trivial fix to ProblemList 2 serviceability/dcmd/gc tests with ZGC on macOS-all.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issues

• JDK-8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
• JDK-8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5691/head:pull/5691
$ git checkout pull/5691

Update a local copy of the PR:
$ git checkout pull/5691
$ git pull https://git.openjdk.java.net/jdk pull/5691/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5691

View PR using the GUI difftool:
$ git pr show -t 5691

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5691.diff

[dcubed-ojdk]

/label add hotspot-runtime
/label add serviceability

[bridgekeeper]

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dcubed-ojdk
The hotspot-runtime label was successfully added.

[openjdk]

@dcubed-ojdk
The serviceability label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (c53c1cce)
• 00: Full (7d5c636a)

[dcubed-ojdk]

/issue JDK-8274312
/issue JDK-8274313

[openjdk]

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

[openjdk]

@dcubed-ojdk
Adding additional issue to issue list: 8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests.

[tstuefe]

Looks good and trivial.

[openjdk]

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274312: ProblemList 2 serviceability/dcmd/gc tests with ZGC on macos-all
8274313: ProblemList sun/tools/jmap/BasicJMapTest.java subtests

Reviewed-by: stuefe, sspitsyn, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

Looks good.
Thanks,
Serguei

[dholmes-ora]

I didn't think it was necessary to enumerate subtests like this?

[dcubed-ojdk]

I didn't think so either, but the original ProblemListing bug:

JDK-8274294 ProblemList sun/tools/jmap/BasicJMapTest.java

didn't do the job.

[dcubed-ojdk]

@tstuefe, @sspitsyn and @dholmes-ora - Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit ab28db1.
Since your change was applied there have been 2 commits pushed to the master branch:

• 8c122af: 8274314: Typo in WatchService#poll(long timeout, TimeUnit unit) javadoc
• 9bc865d: 8273960: Redundant condition in Metadata.TypeComparator.compare

Your commit was automatically rebased without conflicts.

[openjdk]

@dcubed-ojdk Pushed as commit ab28db1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.