8274899: Replace usages of Collections.sort with List.sort call in jdk.hotspot.agent

[turbanoff]

Collections.sort is just a wrapper, so it is better to use an instance method directly.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274899: Replace usages of Collections.sort with List.sort call in jdk.hotspot.agent

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Chris Plummer (@plummercj - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5697/head:pull/5697
$ git checkout pull/5697

Update a local copy of the PR:
$ git checkout pull/5697
$ git pull https://git.openjdk.java.net/jdk pull/5697/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5697

View PR using the GUI difftool:
$ git pr show -t 5697

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5697.diff

[bridgekeeper]

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following labels will be automatically applied to this pull request:

• hotspot-gc
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0abf9527)

[sspitsyn]

Andrey,
Nice simplification. It looks good to me.
Thanks,
Serguei

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274899: Replace usages of Collections.sort with List.sort call in jdk.hotspot.agent

Reviewed-by: sspitsyn, cjplummer, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 265 new commits pushed to the master branch:

• 002c538: 8275287: Relax memory ordering constraints on updating instance class and array class counters
• 98ab4b0: 8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"
• dcd6e0d: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline
• d17d81a: 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator
• a4491f2: 8275413: Remove unused InstanceKlass::set_array_klasses() method
• 9d191fc: 8245095: Implementation of JEP 408: Simple Web Server
• 947d52c: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS
• a03119c: 8275436: [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect
• bad75e6: 8275150: URLClassLoaderTable should store OopHandle instead of Handle
• 72a976e: 8266936: Add a finalization JFR event
• ... and 255 more: https://git.openjdk.java.net/jdk/compare/5756385c2bb106917f45ba71b24cf1645f702ebf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sspitsyn, @plummercj, @albertnetymk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[turbanoff]

/integrate

[openjdk]

@turbanoff
Your change (at version 0abf952) is now ready to be sponsored by a Committer.

[albertnetymk]

/sponsor

[openjdk]

Going to push as commit a579483.
Since your change was applied there have been 265 commits pushed to the master branch:

• 002c538: 8275287: Relax memory ordering constraints on updating instance class and array class counters
• 98ab4b0: 8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"
• dcd6e0d: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline
• d17d81a: 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator
• a4491f2: 8275413: Remove unused InstanceKlass::set_array_klasses() method
• 9d191fc: 8245095: Implementation of JEP 408: Simple Web Server
• 947d52c: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS
• a03119c: 8275436: [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect
• bad75e6: 8275150: URLClassLoaderTable should store OopHandle instead of Handle
• 72a976e: 8266936: Add a finalization JFR event
• ... and 255 more: https://git.openjdk.java.net/jdk/compare/5756385c2bb106917f45ba71b24cf1645f702ebf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk @turbanoff Pushed as commit a579483.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.