New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253563: Change sun.security.jca.Providers.threadLists to be ThreadLocal #570
Conversation
👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into |
/label add security |
@valeriepeng |
@valeriepeng This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@valeriepeng Since your change was applied there have been 46 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit df1f132. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Could someone help reviewing this one-line change? This changes the provider list used during jar verification from InheritableThreadLocal to ThreadLocal. Existing usage and handling uses this field as temporary thread-specific provider list for jar verification. There seems to be no reason for it to be InheritableThreadLocal.
Existing regression tests pass with this change.
Thanks,
Valerie
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/570/head:pull/570
$ git checkout pull/570