8225122: Test AncestorResized.java fails when Windows desktop is scaled. #5711
Conversation
|
|
| @@ -112,177 +104,12 @@ private static void init() | |||
| // ... and start resizing | |||
| robot.mousePress( InputEvent.BUTTON1_MASK ); | |||
| robot.mouseMove(bounds.x + bounds.width + 20, bounds.y + bounds.height + 15); | |||
| Util.waitForIdle(robot); | |||
| robot.mouseRelease(InputEvent.BUTTON1_MASK); | |||
There was a problem hiding this comment.
This is the actual change, mouseRelease is moved from the end of the test to the line above.
Webrevs
|
|
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Does anybody have any other suggestions? |
|
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Any volunteers? |
|
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Any volunteers? |
| @@ -61,8 +54,7 @@ public void ancestorResized(HierarchyEvent ce) { | |||
| } | |||
| } | |||
|
|
|||
| private static void init() | |||
| { | |||
| public static void main(String[] args) throws Exception { | |||
| Frame frame; | |||
There was a problem hiding this comment.
Not a big fan of the split declaration and initialization of all the variables but that existed before the fix and it is purely cosmetic. Other than that looks good.
|
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
|
/integrate |
openjdk
bot
removed
ready
This test depends on the next windows UI performance option:
“Show window contents while dragging”, see https://answers.microsoft.com/en-us/windows/forum/all/in-windows-7-how-do-i-show-window-contents-while/18e3aee2-bcc7-4005-a45d-c5613cf6eb3c
In the default configuration, the windows may decide that the system is slow and this option should be disabled. I have found that this usually happens in the virtual environment.
When that option is disabled the resize events have come when the user completes the resize, before that the only border "rectangle" is moved.
This fix changes the test to release the mouse and complete the resize, and only after that checks the result.
Also, some old machinery is removed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5711/head:pull/5711$ git checkout pull/5711Update a local copy of the PR:
$ git checkout pull/5711$ git pull https://git.openjdk.java.net/jdk pull/5711/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5711View PR using the GUI difftool:
$ git pr show -t 5711Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5711.diff