Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253765: C2: Control randomization in StressLCM and StressGCM #572

Closed
wants to merge 2 commits into from

Conversation

robcasloz
Copy link
Contributor

@robcasloz robcasloz commented Oct 9, 2020

Use the compilation-local seed in StressLCM and StressGCM rather than the global one. As a consequence, these options use by default a fresh seed in every compilation, unless StressSeed=N is specified, in which case they behave deterministically. Annotate tests that use StressLCM and StressGCM with the stress and randomness keys to reflect this change in default behavior.

Tested on tier1 and on all test cases that use StressLCM and StressGCM (10 times each).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ⏳ (3/3 running) ⏳ (2/2 running) ⏳ (2/2 running)

Issue

  • JDK-8253765: C2: Control randomization in StressLCM and StressGCM

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/572/head:pull/572
$ git checkout pull/572

Use the compilation-local seed in 'StressLCM' and 'StressGCM' rather than the
global one. As a consequence, these options use by default a fresh seed in every
compilation, unless 'StressSeed=N' is specified, in which case they behave
deterministically. Annotate tests that use 'StressLCM' and 'StressGCM' with the
'stress' and 'randomness' keys to reflect this change in default behavior.
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2020

👋 Welcome back robcasloz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@robcasloz
Copy link
Contributor Author

/summary
Use the compilation-local seed in 'StressLCM' and 'StressGCM' rather than the
global one. As a consequence, these options use by default a fresh seed in every
compilation, unless 'StressSeed=N' is specified, in which case they behave
deterministically. Annotate tests that use 'StressLCM' and 'StressGCM' with the
'stress' and 'randomness' keys to reflect this change in default behavior.

@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@robcasloz Setting summary to:

Use the compilation-local seed in 'StressLCM' and 'StressGCM' rather than the
global one. As a consequence, these options use by default a fresh seed in every
compilation, unless 'StressSeed=N' is specified, in which case they behave
deterministically. Annotate tests that use 'StressLCM' and 'StressGCM' with the
'stress' and 'randomness' keys to reflect this change in default behavior.

@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@robcasloz The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Oct 9, 2020
@robcasloz
Copy link
Contributor Author

/label remove hotspot,shenandoah

@robcasloz
Copy link
Contributor Author

/label add hotspot-compiler

@openjdk openjdk bot removed hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Oct 9, 2020
@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@robcasloz
The hotspot label was successfully removed.

The shenandoah label was successfully removed.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 9, 2020
@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@robcasloz
The hotspot-compiler label was successfully added.

@robcasloz robcasloz marked this pull request as ready for review October 9, 2020 08:30
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2020

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253765: C2: Control randomization in StressLCM and StressGCM

Use the compilation-local seed in 'StressLCM' and 'StressGCM' rather than the
global one. As a consequence, these options use by default a fresh seed in every
compilation, unless 'StressSeed=N' is specified, in which case they behave
deterministically. Annotate tests that use 'StressLCM' and 'StressGCM' with the
'stress' and 'randomness' keys to reflect this change in default behavior.

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • 6620b61: 8254573: Shenandoah: Streamline/inline native-LRB entry point
  • a6c23b7: 8253923: C2 doesn't always run loop opts for compilations that include loops
  • dfe8ba6: 8254320: Shenandoah: C2 native LRB should activate for non-cset objects
  • 295a44a: 8254558: Remove unimplemented Arguments::do_pd_flag_adjustments
  • 0fab73e: 8254560: Shenandoah: Concurrent Strong Roots logging is incorrect
  • 638f910: 8254559: Remove unimplemented JVMFlag::get_locked_message_ext
  • 0ec1d63: 8253117: Replace HTML tables in javadoc summaries with CSS grid elements
  • 54bbe76: 8251544: CTW: C2 fails with assert(no_dead_loop) failed: dead loop detected
  • 13fe054: 8253588: C1: assert(false) failed: unknown register on x86_32 only with -XX:+TraceLinearScanLevel=4
  • 59378a1: 8254164: G1 only removes self forwarding pointers for last collection set increment
  • ... and 49 more: https://git.openjdk.java.net/jdk/compare/9cdfd0fafe9aa88b6556a00b3b71efb0f99c5249...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 9, 2020
@robcasloz
Copy link
Contributor Author

Good.

Thanks for reviewing Vladimir!

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

src/hotspot/share/opto/c2_globals.hpp Show resolved Hide resolved
@robcasloz
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 12, 2020
@openjdk
Copy link

openjdk bot commented Oct 12, 2020

@robcasloz
Your change (at version 85dc52b) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Oct 12, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored labels Oct 12, 2020
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2020
@openjdk
Copy link

openjdk bot commented Oct 12, 2020

@TobiHartmann @robcasloz Since your change was applied there have been 59 commits pushed to the master branch:

  • 6620b61: 8254573: Shenandoah: Streamline/inline native-LRB entry point
  • a6c23b7: 8253923: C2 doesn't always run loop opts for compilations that include loops
  • dfe8ba6: 8254320: Shenandoah: C2 native LRB should activate for non-cset objects
  • 295a44a: 8254558: Remove unimplemented Arguments::do_pd_flag_adjustments
  • 0fab73e: 8254560: Shenandoah: Concurrent Strong Roots logging is incorrect
  • 638f910: 8254559: Remove unimplemented JVMFlag::get_locked_message_ext
  • 0ec1d63: 8253117: Replace HTML tables in javadoc summaries with CSS grid elements
  • 54bbe76: 8251544: CTW: C2 fails with assert(no_dead_loop) failed: dead loop detected
  • 13fe054: 8253588: C1: assert(false) failed: unknown register on x86_32 only with -XX:+TraceLinearScanLevel=4
  • 59378a1: 8254164: G1 only removes self forwarding pointers for last collection set increment
  • ... and 49 more: https://git.openjdk.java.net/jdk/compare/9cdfd0fafe9aa88b6556a00b3b71efb0f99c5249...master

Your commit was automatically rebased without conflicts.

Pushed as commit 05459df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants