8253765: C2: Control randomization in StressLCM and StressGCM #572

robcasloz · 2020-10-09T08:09:05Z

Use the compilation-local seed in StressLCM and StressGCM rather than the global one. As a consequence, these options use by default a fresh seed in every compilation, unless StressSeed=N is specified, in which case they behave deterministically. Annotate tests that use StressLCM and StressGCM with the stress and randomness keys to reflect this change in default behavior.

Tested on tier1 and on all test cases that use StressLCM and StressGCM (10 times each).

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	⏳ (3/3 running)	⏳ (2/2 running)	⏳ (2/2 running)

Issue

JDK-8253765: C2: Control randomization in StressLCM and StressGCM

Reviewers

Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 64c6538
Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to 64c6538

Download

$ git fetch https://git.openjdk.java.net/jdk pull/572/head:pull/572
$ git checkout pull/572

Use the compilation-local seed in 'StressLCM' and 'StressGCM' rather than the global one. As a consequence, these options use by default a fresh seed in every compilation, unless 'StressSeed=N' is specified, in which case they behave deterministically. Annotate tests that use 'StressLCM' and 'StressGCM' with the 'stress' and 'randomness' keys to reflect this change in default behavior.

bridgekeeper · 2020-10-09T08:09:30Z

👋 Welcome back robcasloz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

robcasloz · 2020-10-09T08:10:38Z

/summary
Use the compilation-local seed in 'StressLCM' and 'StressGCM' rather than the
global one. As a consequence, these options use by default a fresh seed in every
compilation, unless 'StressSeed=N' is specified, in which case they behave
deterministically. Annotate tests that use 'StressLCM' and 'StressGCM' with the
'stress' and 'randomness' keys to reflect this change in default behavior.

openjdk · 2020-10-09T08:12:14Z

@robcasloz Setting summary to:

Use the compilation-local seed in 'StressLCM' and 'StressGCM' rather than the
global one. As a consequence, these options use by default a fresh seed in every
compilation, unless 'StressSeed=N' is specified, in which case they behave
deterministically. Annotate tests that use 'StressLCM' and 'StressGCM' with the
'stress' and 'randomness' keys to reflect this change in default behavior.

openjdk · 2020-10-09T08:14:33Z

@robcasloz The following labels will be automatically applied to this pull request:

hotspot
shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

robcasloz · 2020-10-09T08:23:00Z

/label remove hotspot,shenandoah

robcasloz · 2020-10-09T08:23:37Z

/label add hotspot-compiler

openjdk · 2020-10-09T08:25:30Z

@robcasloz
The hotspot label was successfully removed.

The shenandoah label was successfully removed.

openjdk · 2020-10-09T08:26:28Z

@robcasloz
The hotspot-compiler label was successfully added.

mlbridge · 2020-10-09T08:35:26Z

Webrevs

01: Full - Incremental (85dc52b)
00: Full (64c6538)

vnkozlov

Good.

openjdk · 2020-10-09T23:39:22Z

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253765: C2: Control randomization in StressLCM and StressGCM

Use the compilation-local seed in 'StressLCM' and 'StressGCM' rather than the
global one. As a consequence, these options use by default a fresh seed in every
compilation, unless 'StressSeed=N' is specified, in which case they behave
deterministically. Annotate tests that use 'StressLCM' and 'StressGCM' with the
'stress' and 'randomness' keys to reflect this change in default behavior.

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

6620b61: 8254573: Shenandoah: Streamline/inline native-LRB entry point
a6c23b7: 8253923: C2 doesn't always run loop opts for compilations that include loops
dfe8ba6: 8254320: Shenandoah: C2 native LRB should activate for non-cset objects
295a44a: 8254558: Remove unimplemented Arguments::do_pd_flag_adjustments
0fab73e: 8254560: Shenandoah: Concurrent Strong Roots logging is incorrect
638f910: 8254559: Remove unimplemented JVMFlag::get_locked_message_ext
0ec1d63: 8253117: Replace HTML tables in javadoc summaries with CSS grid elements
54bbe76: 8251544: CTW: C2 fails with assert(no_dead_loop) failed: dead loop detected
13fe054: 8253588: C1: assert(false) failed: unknown register on x86_32 only with -XX:+TraceLinearScanLevel=4
59378a1: 8254164: G1 only removes self forwarding pointers for last collection set increment
... and 49 more: https://git.openjdk.java.net/jdk/compare/9cdfd0fafe9aa88b6556a00b3b71efb0f99c5249...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

robcasloz · 2020-10-12T08:35:00Z

Good.

Thanks for reviewing Vladimir!

TobiHartmann

Otherwise looks good.

src/hotspot/share/opto/c2_globals.hpp

robcasloz · 2020-10-12T11:24:12Z

/integrate

openjdk · 2020-10-12T11:25:02Z

@robcasloz
Your change (at version 85dc52b) is now ready to be sponsored by a Committer.

TobiHartmann · 2020-10-12T11:39:50Z

/sponsor

openjdk · 2020-10-12T11:41:14Z

@TobiHartmann @robcasloz Since your change was applied there have been 59 commits pushed to the master branch:

6620b61: 8254573: Shenandoah: Streamline/inline native-LRB entry point
a6c23b7: 8253923: C2 doesn't always run loop opts for compilations that include loops
dfe8ba6: 8254320: Shenandoah: C2 native LRB should activate for non-cset objects
295a44a: 8254558: Remove unimplemented Arguments::do_pd_flag_adjustments
0fab73e: 8254560: Shenandoah: Concurrent Strong Roots logging is incorrect
638f910: 8254559: Remove unimplemented JVMFlag::get_locked_message_ext
0ec1d63: 8253117: Replace HTML tables in javadoc summaries with CSS grid elements
54bbe76: 8251544: CTW: C2 fails with assert(no_dead_loop) failed: dead loop detected
13fe054: 8253588: C1: assert(false) failed: unknown register on x86_32 only with -XX:+TraceLinearScanLevel=4
59378a1: 8254164: G1 only removes self forwarding pointers for last collection set increment
... and 49 more: https://git.openjdk.java.net/jdk/compare/9cdfd0fafe9aa88b6556a00b3b71efb0f99c5249...master

Your commit was automatically rebased without conflicts.

Pushed as commit 05459df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Oct 9, 2020

openjdk bot removed hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Oct 9, 2020

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 9, 2020

robcasloz marked this pull request as ready for review October 9, 2020 08:30

openjdk bot added the rfr Pull request is ready for review label Oct 9, 2020

vnkozlov approved these changes Oct 9, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 9, 2020

TobiHartmann approved these changes Oct 12, 2020

View reviewed changes

src/hotspot/share/opto/c2_globals.hpp Show resolved Hide resolved

Close parenthesis in option description

85dc52b

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 12, 2020

openjdk bot closed this Oct 12, 2020

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored labels Oct 12, 2020

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2020

lfoltan mentioned this pull request May 21, 2025

8357220: Introduce a BSMAttributeEntry struct #25298

Open

3 tasks

8253765: C2: Control randomization in StressLCM and StressGCM #572

8253765: C2: Control randomization in StressLCM and StressGCM #572

Uh oh!

Conversation

robcasloz commented Oct 9, 2020 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Testing

Issue

Reviewers

Download

Uh oh!

bridgekeeper bot commented Oct 9, 2020

Uh oh!

robcasloz commented Oct 9, 2020

Uh oh!

openjdk bot commented Oct 9, 2020

Uh oh!

openjdk bot commented Oct 9, 2020

Uh oh!

robcasloz commented Oct 9, 2020

Uh oh!

robcasloz commented Oct 9, 2020

Uh oh!

openjdk bot commented Oct 9, 2020

Uh oh!

openjdk bot commented Oct 9, 2020

Uh oh!

mlbridge bot commented Oct 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

vnkozlov left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Oct 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robcasloz commented Oct 12, 2020

Uh oh!

TobiHartmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

robcasloz commented Oct 12, 2020

Uh oh!

openjdk bot commented Oct 12, 2020

Uh oh!

TobiHartmann commented Oct 12, 2020

Uh oh!

openjdk bot commented Oct 12, 2020

Uh oh!

Uh oh!

robcasloz commented Oct 9, 2020 •

edited by openjdk bot

Loading

mlbridge bot commented Oct 9, 2020 •

edited

Loading

openjdk bot commented Oct 9, 2020 •

edited

Loading