New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274401: C2: GraphKit::load_array_element bypasses Access API #5727
8274401: C2: GraphKit::load_array_element bypasses Access API #5727
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seems fine.
Do you have a test case which shows the issue?
The only place where we currently have a real bug is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Martin,
did one of the jtreg tests fail? Maybe you could share which it was.
Maybe a @bug 8274401 in that test would be useful.
The change looks good to me.
Best regards,
Goetz.
We found the issue by running jvm2008 crypto.aes with our experimental ZGC on PPC64 with FullGCALot. |
Thanks for the explanation. |
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 35 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for the reviews! |
Going to push as commit a8210c5.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit a8210c5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
C2: GraphKit::load_array_element only creates nodes for loading a raw element from the given array. This is wrong when the element is an Oop which needs a load barrier for some GCs.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5727/head:pull/5727
$ git checkout pull/5727
Update a local copy of the PR:
$ git checkout pull/5727
$ git pull https://git.openjdk.java.net/jdk pull/5727/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5727
View PR using the GUI difftool:
$ git pr show -t 5727
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5727.diff