8254285: G1: Remove "What is this about" comment in G1CollectedHeap.cpp

[tschatzl]

Hi all,

can I get quick reviews for this imho trivial change that removes some strange comment leftover from initial G1 import reading:

// FIXME: what is this about?
// I'm ignoring the "fill_newgen()" call if "alloc_event_enabled"
// is set.

None of the referenced identifiers are in any kind of recent code base (looking back to some pre-g1 7u changes). In its current context it does not make sense either and apparently whatever omission the comment suggests has not hurt G1 for years.

Testing: local compilation

Thanks,
Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build / test	✔️ (0/0 passed)	✔️ (0/0 passed)	✔️ (0/0 passed)

Issue

• JDK-8254285: G1: Remove "What is this about" comment in G1CollectedHeap.cpp

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Stefan Johansson (@kstefanj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/573/head:pull/573
$ git checkout pull/573

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[shipilev]

Looks fine and trivial.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254285: G1: Remove "What is this about" comment in G1CollectedHeap.cpp

Reviewed-by: shade, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 0230781: 8254175: Build no-pch configuration in debug mode for submit checks

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9681291)

[kstefanj]

Looks good.

[tschatzl]

Thanks @shipilev @kstefanj for your reviews.

/integrate

[openjdk]

@tschatzl Since your change was applied there has been 1 commit pushed to the master branch:

• 0230781: 8254175: Build no-pch configuration in debug mode for submit checks

Your commit was automatically rebased without conflicts.

Pushed as commit a95590d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.