Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274505: Too weak variable type leads to unnecessary cast in java.desktop #5731

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 28, 2021

Such casts are actually redundant, but they are inserted, because variable is declared with too weak type.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274505: Too weak variable type leads to unnecessary cast in java.desktop

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5731/head:pull/5731
$ git checkout pull/5731

Update a local copy of the PR:
$ git checkout pull/5731
$ git pull https://git.openjdk.java.net/jdk pull/5731/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5731

View PR using the GUI difftool:
$ git pr show -t 5731

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5731.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Sep 28, 2021
@turbanoff turbanoff changed the title [PATCH] Too weak variable type leads to unnecessary cast in java.desktop 8274505: Too weak variable type leads to unnecessary cast in java.desktop Sep 29, 2021
@openjdk openjdk bot added the rfr label Sep 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2021

Webrevs

mrserb
mrserb approved these changes Sep 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274505: Too weak variable type leads to unnecessary cast in java.desktop

Reviewed-by: serb, kizune, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • 3d7671b: 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS
  • c05dc26: 8274435: EXCEPTION_ACCESS_VIOLATION in BFSClosure::closure_impl
  • cc14c6f: 8274227: Remove "impl.prefix" jdk system property usage from InetAddress
  • 292d7bb: 8274363: Transitively sealed classes not considered exhaustive in switches
  • 1887028: 8269113: Javac throws when compiling switch (null)
  • b7b78ff: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines
  • 5e4b514: 8274550: c2i entry barriers read int as long on PPC
  • 2e690ba: 8274322: Problems with oopDesc construction
  • a8edd1b: 8274527: Minimal VM build fails after JDK-8273459
  • 7326481: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/6a573b888d4d3322b9165562f85e1b7b781a5ff1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @azuev-java, @pankaj-bansal) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 30, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 1, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@turbanoff
Your change (at version 5b81844) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 2, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2021

Going to push as commit 9ca6bf0.
Since your change was applied there have been 55 commits pushed to the master branch:

  • 0786d8b: 8268435: (ch) ChannelInputStream could override readAllBytes
  • bb4500d: 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures
  • 05d3860: 8274605: Fix predicate guarantees on returned values in (Doc)SourcePositions
  • 3d7671b: 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS
  • c05dc26: 8274435: EXCEPTION_ACCESS_VIOLATION in BFSClosure::closure_impl
  • cc14c6f: 8274227: Remove "impl.prefix" jdk system property usage from InetAddress
  • 292d7bb: 8274363: Transitively sealed classes not considered exhaustive in switches
  • 1887028: 8269113: Javac throws when compiling switch (null)
  • b7b78ff: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines
  • 5e4b514: 8274550: c2i entry barriers read int as long on PPC
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/6a573b888d4d3322b9165562f85e1b7b781a5ff1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 2, 2021

@mrserb @turbanoff Pushed as commit 9ca6bf0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the redundant_casts_in_java.desktop_weak_variable_type branch Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
4 participants