Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274381 missing CAccessibility definitions in JNI code #5732

Closed
wants to merge 2 commits into from

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Sep 28, 2021

accessibilityHitTest in JavaComponentAccessibility and getAxComponentSize in JavaAccessibilityUtilities use but do not define sjc_CAccessibility. It works when sjc_CAccessibility is defined by other methods, otherwise it crashes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274381: missing CAccessibility definitions in JNI code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5732/head:pull/5732
$ git checkout pull/5732

Update a local copy of the PR:
$ git checkout pull/5732
$ git pull https://git.openjdk.java.net/jdk pull/5732/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5732

View PR using the GUI difftool:
$ git pr show -t 5732

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5732.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2021

👋 Welcome back savoptik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 28, 2021
@savoptik
Copy link
Contributor Author

/reviewer credit @forantar

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@savoptik The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@savoptik
Reviewer ant successfully credited.

@mlbridge
Copy link

mlbridge bot commented Sep 28, 2021

Webrevs

@pankaj-bansal
Copy link

Could you please look at #5702. I see that Phil just fixed similar thing in JavaComponentAccessibility.m. Looks like we have same/similar function present in two classes doing exactly the same thing. Is it possible we can get rid of one of these two?

JavaComponentAccessibility.m has

  • (id)accessibilityHitTest:(NSPoint)point withEnv:(JNIEnv *)env

CommonComponentAccessibility.m has

  • (id)accessibilityHitTest:(NSPoint)point

@savoptik
Copy link
Contributor Author

savoptik commented Sep 28, 2021 via email

Copy link

@pankaj-bansal pankaj-bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274381: missing CAccessibility definitions in JNI code

Reviewed-by: pbansal, ant, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 79865cd: 8274259: G1: assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe after JDK-8270009
  • 961dcff: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@pankaj-bansal, @forantar, @azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2021
@@ -51,6 +51,7 @@

NSSize getAxComponentSize(JNIEnv *env, jobject axComponent, jobject component)
{
GET_CACCESSIBILITY_CLASS_RETURN(nil);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use NSZeroSize as the return value here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@savoptik
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@savoptik
Your change (at version afa6206) is now ready to be sponsored by a Committer.

@forantar
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

Going to push as commit be40373.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 79865cd: 8274259: G1: assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe after JDK-8270009
  • 961dcff: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@forantar @savoptik Pushed as commit be40373.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@savoptik
Copy link
Contributor Author

/backport 17u

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@savoptik Unknown command backport - for a list of valid commands use /help.

@savoptik
Copy link
Contributor Author

/backport 17u

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@savoptik Unknown command backport - for a list of valid commands use /help.

@forantar
Copy link
Contributor

/help

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@forantar Available commands:

  • covered - used when employer has signed the OCA
  • help - shows this text
  • signed - used after signing the OCA
  • test - used to run tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants