8274430: Remove some debug error printing code added in JDK-8017163

[tschatzl]

Hi all,

can I have reviews for this change that undoes some logging changes from JDK-8017163, in particular it added the XXX card set lines in the output as shown in an example below:

[171.616s][1632757560415ms][error][gc,verify ] GC(129) Field 0x00000007fb1008f0 of obj 0x00000007fb1008d8 in region 1485:(O)[0x00000007fb000000,0x00000
[171.616s][1632757560415ms][error][gc,verify ] GC(129) NULL card setjava.lang.invoke.MethodType$ConcurrentWeakInternSet$WeakEntry
[...]
points to obj 0x00000004d9abd4c8 in region 683:(S)[0x00000004d9000000,0x00000004da000000,0x00000004da000000] remset Complete

This string would indicate which card set container does not have the requested remembered set entry. This is unnecessary information, as the "points to obj" string later shows that there should be a remset to this region already, and otherwise only interesting for debugging.

Testing: gha

Thanks,
Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274430: Remove some debug error printing code added in JDK-8017163

Reviewers

• Stefan Johansson (@kstefanj - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5733/head:pull/5733
$ git checkout pull/5733

Update a local copy of the PR:
$ git checkout pull/5733
$ git pull https://git.openjdk.java.net/jdk pull/5733/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5733

View PR using the GUI difftool:
$ git pr show -t 5733

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5733.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cc4226e3)

[kstefanj]

Looks good.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274430: Remove some debug error printing code added in JDK-8017163

Reviewed-by: sjohanss, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 145 new commits pushed to the master branch:

• b60837a: 8272586: emit abstract machine code in hs-err logs
• 97ea9dd: 8274840: Update OS detection code to recognize Windows 11
• 8de7763: 8273152: Refactor CDS FileMapHeader loading code
• 920e707: 8274920: ProblemList 2 VectorAPI tests failing due to "assert(!vbox->is_Phi()) failed"
• 7de2cf8: 8273910: Redundant condition and assignment in java.net.URI
• 8ca0846: 8274407: (tz) Update Timezone Data to 2021c
• 4ab274a: 8274858: Remove unused dictionary_classes_do functions
• 03a8d34: 8273826: Correct Manifest file name and NPE checks
• 722d639: 8274838: runtime/cds/appcds/TestSerialGCWithCDS.java fails on Windows
• 340c715: 8273929: Remove GzipRandomAccess in heap dump test
• ... and 135 more: https://git.openjdk.java.net/jdk/compare/7426fd4c9c0428411d2c4a2c675fcad6646ea90a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @kstefanj @albertnetymk for your reviews.

/integrate

[openjdk]

Going to push as commit b7af890.
Since your change was applied there have been 166 commits pushed to the master branch:

• aaf2401: 8274927: Remove unnecessary G1ArchiveAllocator code
• c55dd36: 8275008: gtest build failure due to stringop-overflow warning with gcc11
• 3edee1e: 8272723: Don't use Access API to access primitive fields
• 49f8ce6: 8274773: [TESTBUG] UnsafeIntrinsicsTest intermittently fails on weak memory model platform
• c032186: 8272968: AArch64: Remove redundant matching rules for commutative ops
• a05873a: 8274952: jdk/jfr/api/consumer/TestRecordedFrameType.java failed when c1 disabled
• 5ecc99b: 8274620: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java is timing out
• 2ff3977: 8275004: CDS build failure with gcc11
• 296f853: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java
• 2c83559: 8274882: Cleanup redundant boxing in java.desktop
• ... and 156 more: https://git.openjdk.java.net/jdk/compare/7426fd4c9c0428411d2c4a2c675fcad6646ea90a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit b7af890.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.