8274340: [BACKOUT] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references

[tschatzl]

Hi all,

please review this backout of JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references because it causes failures with Kitchensink runs.

As the CR indicates, with proper verification these runs fail fairly quickly after 5-20mins with a remembered set verification failure on the discovered field of some j.l.ref.References instances; without that patch multiple instances are already running for an hour without issue (out of 8h). This is enough evidence for me that the change is responsible, backing it out to keep the CI clean(er) as I do not really have an idea why at this time (another merge issue after splitting up the original change?).

Revert applied cleanly except for the hunk in G1PostEvacuateCollectionSetCleanupTask1::G1PostEvacuateCollectionSetCleanupTask1 line 138: an earlier cleanup moved evacuation failure handling to G1YoungCollector, causing some merge problems.

Testing: gha

Thanks,
Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274340: [BACKOUT] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5734/head:pull/5734
$ git checkout pull/5734

Update a local copy of the PR:
$ git checkout pull/5734
$ git pull https://git.openjdk.java.net/jdk pull/5734/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5734

View PR using the GUI difftool:
$ git pr show -t 5734

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5734.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f4403010)

[kimbarrett]

Looks good.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274340: [BACKOUT] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references

Reviewed-by: kbarrett, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• c4d1157: 8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest
• 756d22c: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes
• 5b0c9cc: 8274172: Convert JavadocTester to use NIO
• 2657bcb: 8274136: -XX:+ExitOnOutOfMemoryError calls exit while threads are running
• 53b25bc: 8273459: Update code segment alignment to 64 bytes
• 1a29b1e: 8274016: Replace 'for' cycles with iterator with enhanced-for in java.desktop
• d8a278f: 8274396: Suppress more warnings on non-serializable non-transient instance fields in client libs
• e49e5b5: 8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)
• 2072bc7: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
• 6a477bd: 8274415: Suppress warnings on non-serializable non-transient instance fields in java.xml
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/7426fd4c9c0428411d2c4a2c675fcad6646ea90a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @albertnetymk @kimbarrett for your reviews.

/integrate

[openjdk]

Going to push as commit 1dc8fa9.
Since your change was applied there have been 37 commits pushed to the master branch:

• aaa36cc: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86
• c4d1157: 8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest
• 756d22c: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes
• 5b0c9cc: 8274172: Convert JavadocTester to use NIO
• 2657bcb: 8274136: -XX:+ExitOnOutOfMemoryError calls exit while threads are running
• 53b25bc: 8273459: Update code segment alignment to 64 bytes
• 1a29b1e: 8274016: Replace 'for' cycles with iterator with enhanced-for in java.desktop
• d8a278f: 8274396: Suppress more warnings on non-serializable non-transient instance fields in client libs
• e49e5b5: 8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)
• 2072bc7: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
• ... and 27 more: https://git.openjdk.java.net/jdk/compare/7426fd4c9c0428411d2c4a2c675fcad6646ea90a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 1dc8fa9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.