Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274383 JNI call of getAccessibleSelection on a wrong thread #5735

Closed
wants to merge 2 commits into from

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Sep 28, 2021

[ComboBoxAccessibility accessibilityValue] defines the getAccessibleSelection method on the AccessibleContext class, however the call should go through CAccessibility so that it is executed on the Event Dispatch thread.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274383: JNI call of getAccessibleSelection on a wrong thread

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5735/head:pull/5735
$ git checkout pull/5735

Update a local copy of the PR:
$ git checkout pull/5735
$ git pull https://git.openjdk.java.net/jdk pull/5735/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5735

View PR using the GUI difftool:
$ git pr show -t 5735

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5735.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2021

👋 Welcome back savoptik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@savoptik The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Sep 28, 2021
@savoptik
Copy link
Contributor Author

@savoptik savoptik commented Sep 28, 2021

/reviewer credit @forantar

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@savoptik
Reviewer ant successfully credited.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274383: JNI call of getAccessibleSelection on a wrong thread

Reviewed-by: kizune, ant

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • be40373: 8274381: missing CAccessibility definitions in JNI code
  • 79865cd: 8274259: G1: assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe after JDK-8270009
  • 961dcff: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azuev-java, @forantar) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 28, 2021
DECLARE_METHOD_RETURN(jm_getAccessibleSelection, axContextClass, "getAccessibleSelection", "(I)Ljavax/accessibility/Accessible;", nil);
jobject axSelectedChild = (*env)->CallObjectMethod(env, axContext, jm_getAccessibleSelection, 0);
GET_ACCESSIBLESELECTION_METHOD_RETURN(nil);
jobject axSelection = (*env)->CallStaticObjectMethod(env, sjc_CAccessibility, sjm_getAccessibleSelection, axContext, self->fComponent);
Copy link
Contributor

@forantar forantar Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete axSelection if you forgot.

Copy link
Contributor Author

@savoptik savoptik Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@savoptik
Copy link
Contributor Author

@savoptik savoptik commented Sep 28, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@savoptik
Your change (at version bb51405) is now ready to be sponsored by a Committer.

@forantar
Copy link
Contributor

@forantar forantar commented Sep 28, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

Going to push as commit b36881f.
Since your change was applied there have been 3 commits pushed to the master branch:

  • be40373: 8274381: missing CAccessibility definitions in JNI code
  • 79865cd: 8274259: G1: assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe after JDK-8270009
  • 961dcff: 8273581: Change the mechanism by which JDK loads the platform-specific FontManager class

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@forantar @savoptik Pushed as commit b36881f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link

@pankaj-bansal pankaj-bansal left a comment

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
4 participants